Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issue 83863005: Remove the test_support_chrome target, since it duplicates test_support_common. The latter is wher… (Closed)

Created:
7 years, 1 month ago by jam
Modified:
7 years, 1 month ago
Reviewers:
Paweł Hajdan Jr.
CC:
chromium-reviews
Visibility:
Public.

Description

Remove the test_support_chrome target, since it duplicates test_support_common. The latter is where we already put all test-harness specific code, even if it's only used in browser tests. R=phajdan.jr@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=236856

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -23 lines) Patch
M chrome/chrome_tests.gypi View 6 chunks +0 lines, -23 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
jam
7 years, 1 month ago (2013-11-22 22:02:19 UTC) #1
Paweł Hajdan Jr.
7 years, 1 month ago (2013-11-22 22:22:55 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698