Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(445)

Issue 838603002: Remove support for custom overscroll background (Closed)

Created:
5 years, 11 months ago by ccameron
Modified:
5 years, 11 months ago
Reviewers:
danakj, jam
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, piman+watch_chromium.org, cc-bugs_chromium.org, ben+mojo_chromium.org, darin (slow to review)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove support for custom overscroll background Mac was the only platform to do this, and more recent versions of the OS do not support it anymore. Callers to these functions have been removed from the Blink side. BUG=248742 Committed: https://crrev.com/cbcd8ee26310f2e9a3be4395362a9be1c490c897 Cr-Commit-Position: refs/heads/master@{#312529}

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : #

Patch Set 4 : Rebase (for real) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -149 lines) Patch
M cc/trees/layer_tree_host.h View 1 2 chunks +0 lines, -6 lines 0 comments Download
M cc/trees/layer_tree_host.cc View 1 3 chunks +0 lines, -24 lines 0 comments Download
M cc/trees/layer_tree_host_impl.h View 1 2 chunks +0 lines, -7 lines 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 1 7 chunks +1 line, -53 lines 0 comments Download
M cc/trees/layer_tree_host_impl_unittest.cc View 1 1 chunk +0 lines, -43 lines 0 comments Download
M content/app/resources/content_resources.grd View 1 chunk +0 lines, -2 lines 0 comments Download
D content/app/resources/default_100_percent/overhang_pattern.png View Binary file 0 comments Download
D content/app/resources/default_100_percent/overhang_shadow.png View Binary file 0 comments Download
M content/child/blink_platform_impl.cc View 1 1 chunk +0 lines, -4 lines 0 comments Download
M content/renderer/gpu/render_widget_compositor.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/gpu/render_widget_compositor.cc View 1 1 chunk +0 lines, -4 lines 0 comments Download
M mojo/services/html_viewer/weblayertreeview_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/services/html_viewer/weblayertreeview_impl.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
ccameron
Adding danakj for cc/ and jam for content+mojo OWNER stamp.
5 years, 11 months ago (2015-01-06 19:23:20 UTC) #2
danakj
LGTM
5 years, 11 months ago (2015-01-06 19:43:55 UTC) #3
jam
lgtm
5 years, 11 months ago (2015-01-12 22:27:34 UTC) #4
ccameron
Thanks!
5 years, 11 months ago (2015-01-12 22:31:16 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/838603002/1
5 years, 11 months ago (2015-01-12 22:32:54 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_rel/builds/48859) linux_chromium_gn_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_rel/builds/49100)
5 years, 11 months ago (2015-01-12 22:42:38 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/838603002/20001
5 years, 11 months ago (2015-01-21 23:46:01 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/838603002/60001
5 years, 11 months ago (2015-01-22 00:13:54 UTC) #15
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 11 months ago (2015-01-22 02:20:55 UTC) #16
commit-bot: I haz the power
5 years, 11 months ago (2015-01-22 02:21:35 UTC) #17
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/cbcd8ee26310f2e9a3be4395362a9be1c490c897
Cr-Commit-Position: refs/heads/master@{#312529}

Powered by Google App Engine
This is Rietveld 408576698