Implement browser test for It2Me

chrome/test/remoting/remote_desktop_browsertest.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_TEST_REMOTING_REMOTE_DESKTOP_BROWSERTEST_H_
 #define CHROME_TEST_REMOTING_REMOTE_DESKTOP_BROWSERTEST_H_
 
 #include "base/debug/stack_trace.h"
 #include "chrome/browser/apps/app_browsertest_util.h"
 #include "chrome/browser/chrome_notification_types.h"
@@ skipping 74 matching lines @@
 
   // Test whether the chromoting extension is installed.
   void VerifyChromotingLoaded(bool expected);
 
   // Launch the Chromoting app. If |defer_start| is true, an additional URL
   // parameter is passed to the application, causing it to defer start-up
   // until StartChromotingApp is invoked. Test code can execute arbitrary
   // JavaScript in the context of the app between these two calls, for example
   // to set up appropriate mocks.
   void LaunchChromotingApp(bool defer_start);
+  void LaunchChromotingApp(bool defer_start,
+                           WindowOpenDisposition opt_window_open_disposition);

[Jamie, 2015/01/06 22:18:51]

window_open_disposition is not optional, so the opt_ prefix is not appropriate
here.

[kelvinp, 2015/01/09 22:21:30]

Done.

 
   // If the Chromoting app was launched in deferred mode, tell it to continue
   // its regular start-up sequence.
   void StartChromotingApp();
 
   // Authorize: grant extended access permission to the user's computer.
   void Authorize();
 
   // Authenticate: sign in to google using the credentials provided.
   void Authenticate();
@@ skipping 180 matching lines @@
   // Helper to load a JavaScript file from |path| and inject it to
   // current web_content.  The variable |path| is relative to the directory of
   // the |browsertest| executable.
   static bool LoadScript(content::WebContents* web_contents,
                          const base::FilePath::StringType& path);
 
   // Helper to execute a JavaScript browser test.  It creates an object using
   // the |browserTest.testName| ctor and calls |run| on the created object with
   // |testData|, which can be any arbitrary object literal. The script
   // browser_test.js must be loaded (using LoadScript) before calling this
-  // function.
+  // function.  The JavaScript browser test can optionally return a value when
+  // the test finishes.  The owner must take ownership of |opt_return_value|.
+  void RunJavaScriptTest(content::WebContents* web_contents,
+                         const std::string& testName,
+                         const std::string& testData,
+                         base::Value** opt_return_value);

[Jamie, 2015/01/06 22:18:51]

Similarly, opt_ is not appropriate here (although it would be better if you
could use ExecuteScriptAndExtract* in place of this new method).

[kelvinp, 2015/01/09 22:21:30]

Done.

   void RunJavaScriptTest(content::WebContents* web_contents,
                          const std::string& testName,
                          const std::string& testData);
 
   // Helper to check whether an html element with the given name exists in
   // the active WebContents.
   bool HtmlElementExists(const std::string& name) {
     return ExecuteScriptAndExtractBool(
         "document.getElementById(\"" + name + "\") != null");
   }
@@ skipping 81 matching lines @@
   std::string password_;
   std::string me2me_pin_;
   std::string remote_host_name_;
   std::string extension_name_;
   std::string http_server_;
 };
 
 }  // namespace remoting
 
 #endif  // CHROME_TEST_REMOTING_REMOTE_DESKTOP_BROWSERTEST_H_