Issue 838463004: Remove embedder custom elements.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 838463004: Remove embedder custom elements. (Closed)

Created:
5 years, 11 months ago by esprehn

Modified:
5 years, 11 months ago

Reviewers:
abarth-chromium

CC:
abarth-chromium, mojo-reviews_chromium.org, ojan

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Remove embedder custom elements. In Sky there's no concept of embedder custom elements with different naming rules. Lets remove this machinery. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/3786dd4c4cbd5f42f55b5fcbc4a2304483a11954

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+12 lines, -152 lines)			Patch
M	sky/engine/core/dom/Document.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sky/engine/core/dom/Document.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	sky/engine/core/dom/custom/CustomElement.h	View	2 chunks	+1 line, -9 lines	0 comments	Download
M	sky/engine/core/dom/custom/CustomElement.cpp	View	1 chunk	+2 lines, -19 lines	0 comments	Download
M	sky/engine/core/dom/custom/CustomElementRegistrationContext.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sky/engine/core/dom/custom/CustomElementRegistrationContext.cpp	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	sky/engine/core/dom/custom/CustomElementRegistry.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sky/engine/core/dom/custom/CustomElementRegistry.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	sky/engine/public/BUILD.gn	View	1 chunk	+0 lines, -1 line	0 comments	Download
D	sky/engine/public/web/WebCustomElement.h	View	1 chunk	+0 lines, -55 lines	0 comments	Download
M	sky/engine/public/web/WebDocument.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	sky/engine/web/BUILD.gn	View	1 chunk	+0 lines, -1 line	0 comments	Download
D	sky/engine/web/WebCustomElement.cpp	View	1 chunk	+0 lines, -44 lines	0 comments	Download
M	sky/engine/web/WebDocument.cpp	View	1 chunk	+0 lines, -13 lines	0 comments	Download

Total messages: 4 (1 generated)

esprehn

5 years, 11 months ago (2015-01-14 00:28:01 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
3786dd4c4cbd5f42f55b5fcbc4a2304483a11954 (presubmit successful).