chrome/browser/password_manager/password_store_win.h - Issue 838453003: Open the LoginDatabase on the DB thread, not the UI thread.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/password_manager/password_store_win.h

Issue 838453003: Open the LoginDatabase on the DB thread, not the UI thread. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments from gcasto@. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/password_manager/password_store_factory.cc ('K') | « chrome/browser/password_manager/password_store_mac_unittest.cc ('k') | chrome/browser/password_manager/password_store_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/password_manager/password_store_win.h

diff --git a/chrome/browser/password_manager/password_store_win.h b/chrome/browser/password_manager/password_store_win.h

index 9ef49441e8ef0e4ff39bd86bb4c74727e86f3e2b..a2def0384da8041eb46b7c3093a8af0e4a6f77af 100644

--- a/chrome/browser/password_manager/password_store_win.h

+++ b/chrome/browser/password_manager/password_store_win.h

@@ -22,11 +22,12 @@ class LoginDatabase;

// but also uses IE7 passwords if no others found.

class PasswordStoreWin : public password_manager::PasswordStoreDefault {

public:

- // PasswordWebDataService is only used for IE7 password fetching.

+ // The |login_db| must not have been Init()-ed yet. It will be initialized in

+ // a deferred manner on the DB thread.

Garrett Casto 2015/01/20 07:14:18 Nit: Did you mean to remove the previous comment?

engedy 2015/01/20 10:49:14 Not at all. Must be a merging glitch? Fixed it.

PasswordStoreWin(

scoped_refptr<base::SingleThreadTaskRunner> main_thread_runner,

scoped_refptr<base::SingleThreadTaskRunner> db_thread_runner,

- password_manager::LoginDatabase* login_database,

+ scoped_ptr<password_manager::LoginDatabase> login_db,

const scoped_refptr<PasswordWebDataService>& web_data_service);

// PasswordStore: