Chromium Code Reviews (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

Unified Diff: components/password_manager/core/browser/password_store.h

Issue 838453003: Open the LoginDatabase on the DB thread, not the UI thread. (Closed) Base URL:
Patch Set: Fix nits from vabr@. Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/password_store.h
diff --git a/components/password_manager/core/browser/password_store.h b/components/password_manager/core/browser/password_store.h
index 0844acc184ad3f6eca1006f604a1f56b9549b407..977c2d3236113b6ae27bff0fc81a126ab8fcb4a9 100644
--- a/components/password_manager/core/browser/password_store.h
+++ b/components/password_manager/core/browser/password_store.h
@@ -51,6 +51,11 @@ class PasswordSyncableService;
// Interface for storing form passwords in a platform-specific secure way.
// The login request/manipulation API is not threadsafe and must be used
// from the UI thread.
+// Implementations, however, should carry out most tasks asynchronously on a
+// background thread: the base class provides functionality to facilitate this.
+// I/O heavy initialization should also be performed asynchronously in this
+// manner. If this deferred initialization fails, all subsequent method calls
+// should fail without side effects, return no data, and send no notifications.
// PasswordStoreSync is a hidden base class because only PasswordSyncableService
// needs to access these methods.
class PasswordStore : protected PasswordStoreSync,

Powered by Google App Engine
This is Rietveld 408576698