Chromium Code Reviews (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

Unified Diff: components/password_manager/core/browser/login_database.h

Issue 838453003: Open the LoginDatabase on the DB thread, not the UI thread. (Closed) Base URL:
Patch Set: Fix nits from vabr@. Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/login_database.h
diff --git a/components/password_manager/core/browser/login_database.h b/components/password_manager/core/browser/login_database.h
index 7019338ebb8cdcc1dd0116ca2fdcb0a0584312df..c3e83cff9cec7bd34ac6a1a65bfd29dcfaf9e620 100644
--- a/components/password_manager/core/browser/login_database.h
+++ b/components/password_manager/core/browser/login_database.h
@@ -25,12 +25,12 @@ extern const int kCurrentVersionNumber;
// the login information.
class LoginDatabase {
- LoginDatabase();
+ LoginDatabase(const base::FilePath& db_path);
virtual ~LoginDatabase();
- // Initialize the database with an sqlite file at the given path.
- // If false is returned, no other method should be called.
- bool Init(const base::FilePath& db_path);
+ // Actually creates/opens the database. If false is returned, no other method
+ // should be called.
+ virtual bool Init();
// Reports usage metrics to UMA.
void ReportMetrics(const std::string& sync_username,

Powered by Google App Engine
This is Rietveld 408576698