Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5132)

Unified Diff: chrome/browser/password_manager/password_store_x.cc

Issue 838453003: Open the LoginDatabase on the DB thread, not the UI thread. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix nits from vabr@. Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/password_manager/password_store_x.cc
diff --git a/chrome/browser/password_manager/password_store_x.cc b/chrome/browser/password_manager/password_store_x.cc
index b5eb1489ab8d0f8eb7cbb5d5995c9f2c1e06411f..ab4df822608cfacf6c4fac497d4d9312d5432f8b 100644
--- a/chrome/browser/password_manager/password_store_x.cc
+++ b/chrome/browser/password_manager/password_store_x.cc
@@ -41,12 +41,15 @@ bool AddLoginToBackend(const scoped_ptr<PasswordStoreX::NativeBackend>& backend,
PasswordStoreX::PasswordStoreX(
scoped_refptr<base::SingleThreadTaskRunner> main_thread_runner,
scoped_refptr<base::SingleThreadTaskRunner> db_thread_runner,
- password_manager::LoginDatabase* login_db,
+ scoped_ptr<password_manager::LoginDatabase> login_db,
NativeBackend* backend)
- : PasswordStoreDefault(main_thread_runner, db_thread_runner, login_db),
+ : PasswordStoreDefault(main_thread_runner,
+ db_thread_runner,
+ login_db.Pass()),
backend_(backend),
migration_checked_(!backend),
- allow_fallback_(false) {}
+ allow_fallback_(false) {
+}
PasswordStoreX::~PasswordStoreX() {}
« no previous file with comments | « chrome/browser/password_manager/password_store_x.h ('k') | chrome/browser/password_manager/password_store_x_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698