Chromium Code Reviews (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

Unified Diff: chrome/browser/password_manager/password_store_win.h

Issue 838453003: Open the LoginDatabase on the DB thread, not the UI thread. (Closed) Base URL:
Patch Set: Fix nits from vabr@. Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/password_manager/password_store_win.h
diff --git a/chrome/browser/password_manager/password_store_win.h b/chrome/browser/password_manager/password_store_win.h
index 9ef49441e8ef0e4ff39bd86bb4c74727e86f3e2b..e3fcace379cb4c8543d46fe8eb8a97ab70a20b82 100644
--- a/chrome/browser/password_manager/password_store_win.h
+++ b/chrome/browser/password_manager/password_store_win.h
@@ -22,11 +22,13 @@ class LoginDatabase;
// but also uses IE7 passwords if no others found.
class PasswordStoreWin : public password_manager::PasswordStoreDefault {
- // PasswordWebDataService is only used for IE7 password fetching.
+ // The |login_db| must not have been Init()-ed yet. It will be initialized in
+ // a deferred manner on the DB thread. The |web_data_service| is only used for
+ // IE7 password fetching.
scoped_refptr<base::SingleThreadTaskRunner> main_thread_runner,
scoped_refptr<base::SingleThreadTaskRunner> db_thread_runner,
- password_manager::LoginDatabase* login_database,
+ scoped_ptr<password_manager::LoginDatabase> login_db,
const scoped_refptr<PasswordWebDataService>& web_data_service);
// PasswordStore:
« no previous file with comments | « chrome/browser/password_manager/ ('k') | chrome/browser/password_manager/ » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698