components/password_manager/core/browser/password_store.h - Issue 838453003: Open the LoginDatabase on the DB thread, not the UI thread.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_store.h

Issue 838453003: Open the LoginDatabase on the DB thread, not the UI thread. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Mac namespace fixes. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/password_manager/core/browser/login_database.h ('K') | « components/password_manager/core/browser/login_database.cc ('k') | components/password_manager/core/browser/password_store_default.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/password_store.h

diff --git a/components/password_manager/core/browser/password_store.h b/components/password_manager/core/browser/password_store.h

index b678368cbaa3b742ae3af142ca3a8bdb859b4872..bc7f3c06172bf0de3d347decc9f8b1a777793d63 100644

--- a/components/password_manager/core/browser/password_store.h

+++ b/components/password_manager/core/browser/password_store.h

@@ -51,6 +51,11 @@ class PasswordSyncableService;

// Interface for storing form passwords in a platform-specific secure way.

// The login request/manipulation API is not threadsafe and must be used

// from the UI thread.

+// Implementations, however, should carry out most tasks asynchronously on the

+// the DB thread: the base class provides functionality to facilitate this.

+// I/O heavy initialization should also be performed asynchronously on the DB

+// thread. If deferred initialization fails, all subsequent method calls should

+// fail without side effects, return no data, and trigger no notifications.

// PasswordStoreSync is a hidden base class because only PasswordSyncableService

// needs to access these methods.

class PasswordStore : protected PasswordStoreSync,