components/password_manager/core/browser/login_database.h - Issue 838453003: Open the LoginDatabase on the DB thread, not the UI thread.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/login_database.h

Issue 838453003: Open the LoginDatabase on the DB thread, not the UI thread. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix nits, rework unittests. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/password_manager/password_store_mac_unittest.cc ('K') | « chrome/browser/password_manager/password_store_x_unittest.cc ('k') | components/password_manager/core/browser/login_database.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/login_database.h

diff --git a/components/password_manager/core/browser/login_database.h b/components/password_manager/core/browser/login_database.h

index 7019338ebb8cdcc1dd0116ca2fdcb0a0584312df..c3e83cff9cec7bd34ac6a1a65bfd29dcfaf9e620 100644

--- a/components/password_manager/core/browser/login_database.h

+++ b/components/password_manager/core/browser/login_database.h

@@ -25,12 +25,12 @@ extern const int kCurrentVersionNumber;

// the login information.

class LoginDatabase {

public:

- LoginDatabase();

+ LoginDatabase(const base::FilePath& db_path);

virtual ~LoginDatabase();

- // Initialize the database with an sqlite file at the given path.

- // If false is returned, no other method should be called.

- bool Init(const base::FilePath& db_path);

+ // Actually creates/opens the database. If false is returned, no other method

+ // should be called.

+ virtual bool Init();

// Reports usage metrics to UMA.

void ReportMetrics(const std::string& sync_username,