Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(414)

Unified Diff: components/password_manager/core/browser/password_store_default_unittest.cc

Issue 838453003: Open the LoginDatabase on the DB thread, not the UI thread. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/password_store_default_unittest.cc
diff --git a/components/password_manager/core/browser/password_store_default_unittest.cc b/components/password_manager/core/browser/password_store_default_unittest.cc
index c2b0bbe158436a3336f4c204a74c089b194f0922..20248efca6d1633e4c013ffb3d1bb463270a0c0e 100644
--- a/components/password_manager/core/browser/password_store_default_unittest.cc
+++ b/components/password_manager/core/browser/password_store_default_unittest.cc
@@ -45,15 +45,15 @@ class PasswordStoreDefaultTest : public testing::Test {
protected:
void SetUp() override {
ASSERT_TRUE(temp_dir_.CreateUniqueTempDir());
- login_db_.reset(new LoginDatabase());
- ASSERT_TRUE(login_db_->Init(temp_dir_.path().Append(
- FILE_PATH_LITERAL("login_test"))));
}
void TearDown() override { ASSERT_TRUE(temp_dir_.Delete()); }
+ base::FilePath test_login_db_file_path() const {
+ return temp_dir_.path().Append(FILE_PATH_LITERAL("login_test"));
+ }
+
base::MessageLoopForUI message_loop_;
- scoped_ptr<LoginDatabase> login_db_;
base::ScopedTempDir temp_dir_;
};
@@ -65,7 +65,7 @@ TEST_F(PasswordStoreDefaultTest, NonASCIIData) {
scoped_refptr<PasswordStoreDefault> store(new PasswordStoreDefault(
base::MessageLoopProxy::current(),
base::MessageLoopProxy::current(),
- login_db_.release()));
+ test_login_db_file_path()));
store->Init(syncer::SyncableService::StartSyncFlare());
// Some non-ASCII password form data.
@@ -111,7 +111,7 @@ TEST_F(PasswordStoreDefaultTest, Notifications) {
scoped_refptr<PasswordStoreDefault> store(new PasswordStoreDefault(
base::MessageLoopProxy::current(),
base::MessageLoopProxy::current(),
- login_db_.release()));
+ test_login_db_file_path()));
store->Init(syncer::SyncableService::StartSyncFlare());
PasswordFormData form_data =

Powered by Google App Engine
This is Rietveld 408576698