Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(905)

Side by Side Diff: chrome/browser/password_manager/password_store_win.cc

Issue 838453003: Open the LoginDatabase on the DB thread, not the UI thread. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comments from gcasto@. Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/password_manager/password_store_win.h" 5 #include "chrome/browser/password_manager/password_store_win.h"
6 6
7 #include <map> 7 #include <map>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/logging.h" 10 #include "base/logging.h"
(...skipping 149 matching lines...) Expand 10 before | Expand all | Expand 10 after
160 DCHECK_EQ(PASSWORD_IE7_RESULT, result->GetType()); 160 DCHECK_EQ(PASSWORD_IE7_RESULT, result->GetType());
161 std::vector<autofill::PasswordForm*> matched_forms = 161 std::vector<autofill::PasswordForm*> matched_forms =
162 GetIE7Results(result, *form); 162 GetIE7Results(result, *form);
163 163
164 callback_runner.Run(matched_forms); 164 callback_runner.Run(matched_forms);
165 } 165 }
166 166
167 PasswordStoreWin::PasswordStoreWin( 167 PasswordStoreWin::PasswordStoreWin(
168 scoped_refptr<base::SingleThreadTaskRunner> main_thread_runner, 168 scoped_refptr<base::SingleThreadTaskRunner> main_thread_runner,
169 scoped_refptr<base::SingleThreadTaskRunner> db_thread_runner, 169 scoped_refptr<base::SingleThreadTaskRunner> db_thread_runner,
170 password_manager::LoginDatabase* login_database, 170 scoped_ptr<password_manager::LoginDatabase> login_db,
171 const scoped_refptr<PasswordWebDataService>& web_data_service) 171 const scoped_refptr<PasswordWebDataService>& web_data_service)
172 : PasswordStoreDefault(main_thread_runner, 172 : PasswordStoreDefault(main_thread_runner,
173 db_thread_runner, 173 db_thread_runner,
174 login_database) { 174 login_db.Pass()) {
175 db_handler_.reset(new DBHandler(web_data_service, this)); 175 db_handler_.reset(new DBHandler(web_data_service, this));
176 } 176 }
177 177
178 PasswordStoreWin::~PasswordStoreWin() { 178 PasswordStoreWin::~PasswordStoreWin() {
179 } 179 }
180 180
181 void PasswordStoreWin::ShutdownOnDBThread() { 181 void PasswordStoreWin::ShutdownOnDBThread() {
182 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::DB)); 182 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::DB));
183 db_handler_.reset(); 183 db_handler_.reset();
184 } 184 }
(...skipping 20 matching lines...) Expand all
205 205
206 void PasswordStoreWin::GetLoginsImpl( 206 void PasswordStoreWin::GetLoginsImpl(
207 const PasswordForm& form, 207 const PasswordForm& form,
208 AuthorizationPromptPolicy prompt_policy, 208 AuthorizationPromptPolicy prompt_policy,
209 const ConsumerCallbackRunner& callback_runner) { 209 const ConsumerCallbackRunner& callback_runner) {
210 ConsumerCallbackRunner get_ie7_login = 210 ConsumerCallbackRunner get_ie7_login =
211 base::Bind(&PasswordStoreWin::GetIE7LoginIfNecessary, 211 base::Bind(&PasswordStoreWin::GetIE7LoginIfNecessary,
212 this, form, callback_runner); 212 this, form, callback_runner);
213 PasswordStoreDefault::GetLoginsImpl(form, prompt_policy, get_ie7_login); 213 PasswordStoreDefault::GetLoginsImpl(form, prompt_policy, get_ie7_login);
214 } 214 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698