Open the LoginDatabase on the DB thread, not the UI thread.

components/password_manager/core/browser/login_database.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_LOGIN_DATABASE_H_
 #define COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_LOGIN_DATABASE_H_
 
 #include <string>
 #include <vector>
 
@@ skipping 84 matching lines @@
   bool GetBlacklistLogins(
       std::vector<autofill::PasswordForm*>* forms) const;
 
   // Deletes the login database file on disk, and creates a new, empty database.
   // This can be used after migrating passwords to some other store, to ensure
   // that SQLite doesn't leave fragments of passwords in the database file.
   // Returns true on success; otherwise, whether the file was deleted and
   // whether further use of this login database will succeed is unspecified.
   bool DeleteAndRecreateDatabaseFile();
 
+  // Simulates a failure in the Init() method of any instance. Used for testing.
+  static void set_simulate_init_failure_for_testing(bool fail);

[Garrett Casto, 2015/01/14 08:50:22]

What do you think of instead of adding this field, to keep passing in a
LoginDatabase object where Init() hasn't been called. We can then use a test
only subclass where we override Init() to return false. This keeps test only
code out of the production class. The drawback is that we need to specify this
in the contract of the class that the object passed in has not been Init()'ed. I
think I slightly prefer that setup. What do you think?

[engedy, 2015/01/14 14:36:54]

Sounds great, actually, I did not like the current solution either.

+
  private:
   // Result values for encryption/decryption actions.
   enum EncryptionResult {
     // Success.
     ENCRYPTION_RESULT_SUCCESS,
     // Failure for a specific item (e.g., the encrypted value was manually
     // moved from another machine, and can't be decrypted on this machine).
     // This is presumed to be a permanent failure.
     ENCRYPTION_RESULT_ITEM_FAILURE,
     // A service-level failure (e.g., on a platform using a keyring, the keyring
@@ skipping 34 matching lines @@
   base::FilePath db_path_;
   mutable sql::Connection db_;
   sql::MetaTable meta_table_;
 
   DISALLOW_COPY_AND_ASSIGN(LoginDatabase);
 };
 
 }  // namespace password_manager
 
 #endif  // COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_LOGIN_DATABASE_H_