Remove crypto::GetTPMTokenInfo which is no longer necessary.

Remove crypto::GetTPMTokenInfo which is no longer necessary.

BUG=none

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=237150

[mattm, 2013-11-22 20:30:36]

xiyuan: chrome/browser/
stevenjb: chromeos/
wtc: crypto/

[stevenjb, 2013-11-22 20:34:02]

+rsleevi@ who understands this better than me, and hashimoto@ FYI, but owner
lgtm.

[xiyuan, 2013-11-22 20:37:47]

chrome/browser/ LGTM

[wtc, 2013-11-23 00:42:29]

Patch set 2 LGTM. Please wait for Ryan's approval. dkrahn may also be a good
reviewer for this.

I suspect more code related to tpm_token_name and tpm_user_pin can be removed
from chromeos/cert_loader.cc.

https://codereview.chromium.org/83833003/diff/100001/chromeos/cert_loader.cc
File chromeos/cert_loader.cc (right):

https://codereview.chromium.org/83833003/diff/100001/chromeos/cert_loader.cc#...
chromeos/cert_loader.cc:138: return !tpm_token_name_.empty();

The tpm_token_name_ member is now only used by this method. Perhaps this method
can check tpm_token_slot_id_ != -1 instead, which will allow us to remove the
tpm_token_name_ member.

https://codereview.chromium.org/83833003/diff/100001/chromeos/cert_loader.cc#...
chromeos/cert_loader.cc:311: tpm_user_pin_ = user_pin;

Should we delete the tpm_user_pin_ member and the user_pin input argument?

https://codereview.chromium.org/83833003/diff/100001/crypto/nss_util.cc
File crypto/nss_util.cc (right):

https://codereview.chromium.org/83833003/diff/100001/crypto/nss_util.cc#newco...
crypto/nss_util.cc:597: std::string tpm_token_name_;

Delete the tpm_token_name_ member.

[mattm, 2013-11-23 01:30:49]

https://codereview.chromium.org/83833003/diff/100001/chromeos/cert_loader.cc
File chromeos/cert_loader.cc (right):

https://codereview.chromium.org/83833003/diff/100001/chromeos/cert_loader.cc#...
chromeos/cert_loader.cc:138: return !tpm_token_name_.empty();
On 2013/11/23 00:42:29, wtc wrote:
> 
> The tpm_token_name_ member is now only used by this method. Perhaps this
method
> can check tpm_token_slot_id_ != -1 instead, which will allow us to remove the
> tpm_token_name_ member.

It also has a getter in the header file, which is used by
CertLibrary::IsCertHardwareBackedAt
(chrome/browser/chromeos/options/cert_library.cc), but that could probably be
changed to use PK11_IsHW like in https://codereview.chromium.org/76653003/.

https://codereview.chromium.org/83833003/diff/100001/chromeos/cert_loader.cc#...
chromeos/cert_loader.cc:311: tpm_user_pin_ = user_pin;
On 2013/11/23 00:42:29, wtc wrote:
> 
> Should we delete the tpm_user_pin_ member and the user_pin input argument?

It also has a getter which is used in a few places, some chromeos people would
have to look at whether those could be removed.

https://codereview.chromium.org/83833003/diff/100001/crypto/nss_util.cc
File crypto/nss_util.cc (right):

https://codereview.chromium.org/83833003/diff/100001/crypto/nss_util.cc#newco...
crypto/nss_util.cc:597: std::string tpm_token_name_;
On 2013/11/23 00:42:29, wtc wrote:
> 
> Delete the tpm_token_name_ member.

oops, done.

[Ryan Sleevi, 2013-11-25 06:28:24]

Adding dkrahn. I definitely am not familiar with this aspect of the TPM init
path. I wasn't sure if the user pin was fixed for the TPM (eg: 0000), or if it's
personalized / derived from some personalized info, and then persisted to disk.

Someone from the ChromeOS side should review. I'm happy to take a look at the
threading if there are concerns.

[hashimoto, 2013-11-25 06:33:38]

chrome/browser/ui/webui/chromeos/cryptohome_web_ui_handler.* lgtm

[Darren Krahn, 2013-11-25 17:50:49]

lgtm - The PIN was always 111111 and was a hack to integrate with opencryptoki.

[commit-bot: I haz the power, 2013-11-25 19:37:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mattm@chromium.org/83833003/190001

[commit-bot: I haz the power, 2013-11-25 21:45:07]

Change committed as 237150