Descriptionapp_shell: Fix crash on chrome.runtime.getPackageDirectoryEntry for cros
Because app_shell does not support code in //chrome it cannot register the
special chromeos::FileSystemBackend that handles kFileSystemTypeNativeLocal.
However, code in //storage in IsolatedFileSystemBackend implicitly assumes
that on Chrome OS kFileSystemTypeNativeLocal will be handled elsewhere.
This patch changes IsolatedFileSystemBackend to provide support for
kFileSystemTypeNativeLocal whenever the //storage embedder does not provide a
backend for it. This preserves existing behavior for non-app_shell platforms
and makes app_shell behave like Linux, which works fine.
A better solution would be to refactor chromeos::FileSystemBackend out of
//chrome/browser/chromeos, but that is blocked on componentization of
//chrome/browser/drive, see http://crbug.com/257943
BUG=447027
TEST=existing FileSystem unit and browser tests, manual test of app_shell (see bug for test app)
Committed: https://crrev.com/92d7e42458467aabf64b147e8b95d0f4d205fa3f
Cr-Commit-Position: refs/heads/master@{#310780}
Patch Set 1 #Patch Set 2 : (filesystem) remove spam #
Messages
Total messages: 7 (2 generated)
|