Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 838323003: app_shell: Fix crash on chrome.runtime.getPackageDirectoryEntry for cros (Closed)

Created:
5 years, 11 months ago by James Cook
Modified:
5 years, 11 months ago
Reviewers:
tzik
CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, tzik, jam, nhiroki, darin-cc_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, kinuko+fileapi, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

app_shell: Fix crash on chrome.runtime.getPackageDirectoryEntry for cros Because app_shell does not support code in //chrome it cannot register the special chromeos::FileSystemBackend that handles kFileSystemTypeNativeLocal. However, code in //storage in IsolatedFileSystemBackend implicitly assumes that on Chrome OS kFileSystemTypeNativeLocal will be handled elsewhere. This patch changes IsolatedFileSystemBackend to provide support for kFileSystemTypeNativeLocal whenever the //storage embedder does not provide a backend for it. This preserves existing behavior for non-app_shell platforms and makes app_shell behave like Linux, which works fine. A better solution would be to refactor chromeos::FileSystemBackend out of //chrome/browser/chromeos, but that is blocked on componentization of //chrome/browser/drive, see http://crbug.com/257943 BUG=447027 TEST=existing FileSystem unit and browser tests, manual test of app_shell (see bug for test app) Committed: https://crrev.com/92d7e42458467aabf64b147e8b95d0f4d205fa3f Cr-Commit-Position: refs/heads/master@{#310780}

Patch Set 1 #

Patch Set 2 : (filesystem) remove spam #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -8 lines) Patch
M storage/browser/fileapi/file_system_context.cc View 1 3 chunks +10 lines, -2 lines 0 comments Download
M storage/browser/fileapi/isolated_file_system_backend.h View 2 chunks +10 lines, -1 line 0 comments Download
M storage/browser/fileapi/isolated_file_system_backend.cc View 1 2 chunks +8 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
James Cook
tzik, PTAL (go/appshell has information about app_shell if you need it.)
5 years, 11 months ago (2015-01-08 23:43:11 UTC) #2
tzik
lgtm
5 years, 11 months ago (2015-01-09 02:24:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/838323003/20001
5 years, 11 months ago (2015-01-09 15:04:57 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-09 16:43:38 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-09 16:45:08 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/92d7e42458467aabf64b147e8b95d0f4d205fa3f
Cr-Commit-Position: refs/heads/master@{#310780}

Powered by Google App Engine
This is Rietveld 408576698