Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2320)

Issue 838263006: [turbofan] Make Factory::NewNumber() always return the minus_zero_value. (Closed)

Created:
5 years, 11 months ago by Benedikt Meurer
Modified:
5 years, 11 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Make Factory::NewNumber() always return the minus_zero_value. TEST=unittests R=mstarzinger@chromium.org, dcarney@chromium.org Committed: https://crrev.com/55b3e268b2895e2c09230d39669a75b6ab4e7e4d Cr-Commit-Position: refs/heads/master@{#26080}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -1 line) Patch
M src/factory.cc View 1 chunk +1 line, -1 line 0 comments Download
A test/unittests/factory-unittest.cc View 1 chunk +21 lines, -0 lines 0 comments Download
M test/unittests/unittests.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Benedikt Meurer
5 years, 11 months ago (2015-01-15 15:00:28 UTC) #1
Benedikt Meurer
PTAL
5 years, 11 months ago (2015-01-15 15:00:48 UTC) #2
Michael Starzinger
LGTM.
5 years, 11 months ago (2015-01-15 15:08:30 UTC) #4
Benedikt Meurer
Committed patchset #1 (id:1) manually as 55b3e268b2895e2c09230d39669a75b6ab4e7e4d (presubmit successful).
5 years, 11 months ago (2015-01-15 15:10:11 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/55b3e268b2895e2c09230d39669a75b6ab4e7e4d Cr-Commit-Position: refs/heads/master@{#26080}
5 years, 11 months ago (2015-01-15 15:10:13 UTC) #8
Benedikt Meurer
5 years, 11 months ago (2015-01-15 15:28:37 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/853683009/ by bmeurer@chromium.org.

The reason for reverting is: Breaks the tree.

Powered by Google App Engine
This is Rietveld 408576698