Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 838263005: Revert Revert "Expose chrome policies using Android's App Restrictions Schema" (Closed)

Created:
5 years, 11 months ago by knn
Modified:
5 years, 11 months ago
CC:
chromium-reviews, kerz_chromium, amineer
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert Revert "Expose chrome policies using Android's App Restrictions Schema" Android generates alternate resources when dependent on a higher sdk version then the minsdkversion. This is conflicts with Playstore rules that only permit one resource for App Restrictions. I have now qualified the resource to apply only for sdk > 21 where the App Restriction API was exposed. BUG=448829 BUG=446795 TBR=bartfab@chromium.org Committed: https://crrev.com/f946bbe6862f98c056288ec1242ed6aab9a7d717 Cr-Commit-Position: refs/heads/master@{#311778}

Patch Set 1 #

Patch Set 2 : Actual change that should fix the issue #

Unified diffs Side-by-side diffs Delta from patch set Stats (+174 lines, -21 lines) Patch
M components/policy.gypi View 1 4 chunks +17 lines, -0 lines 0 comments Download
M components/policy/BUILD.gn View 1 4 chunks +20 lines, -0 lines 0 comments Download
M components/policy/tools/generate_policy_source.py View 8 chunks +137 lines, -21 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/838263005/20001
5 years, 11 months ago (2015-01-15 21:01:30 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 11 months ago (2015-01-15 21:01:32 UTC) #5
Bernhard Bauer
LGTM
5 years, 11 months ago (2015-01-15 21:03:24 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/838263005/20001
5 years, 11 months ago (2015-01-15 21:05:05 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-16 00:34:44 UTC) #9
commit-bot: I haz the power
5 years, 11 months ago (2015-01-16 00:35:44 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f946bbe6862f98c056288ec1242ed6aab9a7d717
Cr-Commit-Position: refs/heads/master@{#311778}

Powered by Google App Engine
This is Rietveld 408576698