tools/telemetry/telemetry/util/find_dependencies.py - Issue 838253005: Refactor serving_dirs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/util/find_dependencies.py

Issue 838253005: Refactor serving_dirs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add unittests. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/telemetry/telemetry/util/find_dependencies.py

diff --git a/tools/telemetry/telemetry/util/find_dependencies.py b/tools/telemetry/telemetry/util/find_dependencies.py

index bdabc70d093136eaac12b83c682f878a56ae8e51..8d291537b6921ca7bbfbd82c9b08575c963ab82f 100644

--- a/tools/telemetry/telemetry/util/find_dependencies.py

+++ b/tools/telemetry/telemetry/util/find_dependencies.py

@@ -91,9 +91,6 @@ def FindPageSetDependencies(base_dir):

# Add all of its serving_dirs as dependencies.

for serving_dir in page_set.serving_dirs:

yield serving_dir

- for page in page_set:

- if page.is_file:

- yield page.serving_dir

def FindExcludedFiles(files, options):