tools/telemetry/telemetry/page/__init__.py - Issue 838253005: Refactor serving_dirs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/page/init.py

Issue 838253005: Refactor serving_dirs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add unittests. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/telemetry/telemetry/page/__init__.py

diff --git a/tools/telemetry/telemetry/page/__init__.py b/tools/telemetry/telemetry/page/__init__.py

index 6b78e89ac128c103a0d77a70354f3b0a88e3e630..8b030c1936021284c40d71e713acf2047e5d0933 100644

--- a/tools/telemetry/telemetry/page/__init__.py

+++ b/tools/telemetry/telemetry/page/__init__.py

@@ -201,6 +201,8 @@ class Page(user_story.UserStory):

@property

def serving_dir(self):

+ if not self.is_file:

+ return None

file_path = os.path.realpath(self.file_path)

if os.path.isdir(file_path):

return file_path