chrome/browser/ui/views/extensions/extension_keybinding_registry_views.h - Issue 838253004: MacViews: Fix duplicate definition of ExtensionKeyBindingRegistry::SetShortcutHandlingSuspended

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/extensions/extension_keybinding_registry_views.h

Issue 838253004: MacViews: Fix duplicate definition of ExtensionKeyBindingRegistry::SetShortcutHandlingSuspended (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@DragBookmarks2

Patch Set: Use overrides Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/extension_keybinding_registry.h ('K') | « chrome/browser/ui/cocoa/extensions/extension_keybinding_registry_cocoa.mm ('k') | chrome/browser/ui/views/extensions/extension_keybinding_registry_views.cc » ('j') | chrome/browser/ui/webui/extensions/command_handler.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/extensions/extension_keybinding_registry_views.h

diff --git a/chrome/browser/ui/views/extensions/extension_keybinding_registry_views.h b/chrome/browser/ui/views/extensions/extension_keybinding_registry_views.h

index 65decac1e626819f836f0eeda9779acc4a90c518..3643b66fb634c3cafada1b33aad97fba79898012 100644

--- a/chrome/browser/ui/views/extensions/extension_keybinding_registry_views.h

+++ b/chrome/browser/ui/views/extensions/extension_keybinding_registry_views.h

@@ -37,6 +37,9 @@ class ExtensionKeybindingRegistryViews

Delegate* delegate);

~ExtensionKeybindingRegistryViews() override;

+ // Overridden from ExtensingKeybindingRegistry.

+ void SetShortcutHandlingSuspended(bool suspended) override;

Devlin 2015/01/15 22:41:43 Is there a reason this can't go at line 48 with th

Andre 2015/01/16 18:40:15 Done.

// Overridden from ui::AcceleratorTarget.

bool AcceleratorPressed(const ui::Accelerator& accelerator) override;

bool CanHandleAccelerators() const override;