Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Side by Side Diff: athena/input/accelerator_manager_impl.cc

Issue 838253004: MacViews: Fix duplicate definition of ExtensionKeyBindingRegistry::SetShortcutHandlingSuspended (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@DragBookmarks2
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "athena/input/accelerator_manager_impl.h" 5 #include "athena/input/accelerator_manager_impl.h"
6 6
7 #include "athena/input/public/input_manager.h" 7 #include "athena/input/public/input_manager.h"
8 #include "athena/util/switches.h" 8 #include "athena/util/switches.h"
9 #include "base/logging.h" 9 #include "base/logging.h"
10 #include "ui/aura/window.h" 10 #include "ui/aura/window.h"
11 #include "ui/base/accelerators/accelerator_manager.h" 11 #include "ui/base/accelerators/accelerator_manager.h"
12 #include "ui/base/accelerators/accelerator_processor.h"
12 #include "ui/events/event.h" 13 #include "ui/events/event.h"
13 #include "ui/events/event_target.h" 14 #include "ui/events/event_target.h"
14 #include "ui/views/focus/focus_manager.h" 15 #include "ui/views/focus/focus_manager.h"
15 #include "ui/views/focus/focus_manager_delegate.h"
16 #include "ui/views/focus/focus_manager_factory.h" 16 #include "ui/views/focus/focus_manager_factory.h"
17 #include "ui/wm/core/accelerator_delegate.h" 17 #include "ui/wm/core/accelerator_delegate.h"
18 #include "ui/wm/core/accelerator_filter.h" 18 #include "ui/wm/core/accelerator_filter.h"
19 #include "ui/wm/core/nested_accelerator_controller.h" 19 #include "ui/wm/core/nested_accelerator_controller.h"
20 #include "ui/wm/core/nested_accelerator_delegate.h" 20 #include "ui/wm/core/nested_accelerator_delegate.h"
21 #include "ui/wm/public/dispatcher_client.h" 21 #include "ui/wm/public/dispatcher_client.h"
22 22
23 namespace athena { 23 namespace athena {
24 24
25 // This wrapper interface provides a common interface that handles global 25 // This wrapper interface provides a common interface that handles global
(...skipping 55 matching lines...) Expand 10 before | Expand all | Expand 10 after
81 return false; 81 return false;
82 } 82 }
83 return accelerator_manager_->Process(accelerator); 83 return accelerator_manager_->Process(accelerator);
84 } 84 }
85 85
86 AcceleratorManagerImpl* accelerator_manager_; 86 AcceleratorManagerImpl* accelerator_manager_;
87 87
88 DISALLOW_COPY_AND_ASSIGN(AcceleratorDelegate); 88 DISALLOW_COPY_AND_ASSIGN(AcceleratorDelegate);
89 }; 89 };
90 90
91 class FocusManagerDelegate : public views::FocusManagerDelegate { 91 class AcceleratorProcessor : public ui::AcceleratorProcessor {
92 public: 92 public:
93 explicit FocusManagerDelegate(AcceleratorManagerImpl* accelerator_manager) 93 explicit AcceleratorProcessor(AcceleratorManagerImpl* accelerator_manager)
94 : accelerator_manager_(accelerator_manager) {} 94 : accelerator_manager_(accelerator_manager) {}
95 ~FocusManagerDelegate() override {} 95 ~AcceleratorProcessor() override {}
96 96
97 bool ProcessAccelerator(const ui::Accelerator& accelerator) override { 97 bool ProcessAccelerator(const ui::Accelerator& accelerator) override {
98 return accelerator_manager_->Process(accelerator); 98 return accelerator_manager_->Process(accelerator);
99 } 99 }
100 100
101 ui::AcceleratorTarget* GetCurrentTargetForAccelerator( 101 ui::AcceleratorTarget* GetTargetForAccelerator(
102 const ui::Accelerator& accelerator) const override { 102 const ui::Accelerator& accelerator) const override {
103 return accelerator_manager_->IsRegistered(accelerator, AF_NONE) 103 return accelerator_manager_->IsRegistered(accelerator, AF_NONE)
104 ? accelerator_manager_ 104 ? accelerator_manager_
105 : nullptr; 105 : nullptr;
106 } 106 }
107 107
108 private: 108 private:
109 AcceleratorManagerImpl* accelerator_manager_; 109 AcceleratorManagerImpl* accelerator_manager_;
110 110
111 DISALLOW_COPY_AND_ASSIGN(FocusManagerDelegate); 111 DISALLOW_COPY_AND_ASSIGN(AcceleratorProcessor);
112 }; 112 };
113 113
114 // Key strokes must be sent to web contents to give them a chance to 114 // Key strokes must be sent to web contents to give them a chance to
115 // consume them unless they are reserved, and unhandled key events are 115 // consume them unless they are reserved, and unhandled key events are
116 // sent back to focus manager asynchronously. This installs the athena's 116 // sent back to focus manager asynchronously. This installs the athena's
117 // focus manager that handles athena shell's accelerators. 117 // focus manager that handles athena shell's accelerators.
118 class FocusManagerFactory : public views::FocusManagerFactory { 118 class FocusManagerFactory : public views::FocusManagerFactory {
119 public: 119 public:
120 explicit FocusManagerFactory(AcceleratorManagerImpl* accelerator_manager) 120 explicit FocusManagerFactory(AcceleratorManagerImpl* accelerator_manager)
121 : accelerator_manager_(accelerator_manager) {} 121 : accelerator_manager_(accelerator_manager) {}
122 ~FocusManagerFactory() override {} 122 ~FocusManagerFactory() override {}
123 123
124 views::FocusManager* CreateFocusManager(views::Widget* widget, 124 views::FocusManager* CreateFocusManager(views::Widget* widget,
125 bool desktop_widget) override { 125 bool desktop_widget) override {
126 return new views::FocusManager( 126 views::FocusManager* focus_manager = new views::FocusManager(widget);
127 widget, 127 if (!desktop_widget) {
128 desktop_widget ? nullptr 128 focus_manager->AddAcceleratorPostProcessor(
129 : new FocusManagerDelegate(accelerator_manager_)); 129 new AcceleratorProcessor(accelerator_manager_));
130 }
131 return focus_manager;
130 } 132 }
131 133
132 private: 134 private:
133 AcceleratorManagerImpl* accelerator_manager_; 135 AcceleratorManagerImpl* accelerator_manager_;
134 136
135 DISALLOW_COPY_AND_ASSIGN(FocusManagerFactory); 137 DISALLOW_COPY_AND_ASSIGN(FocusManagerFactory);
136 }; 138 };
137 139
138 class UIAcceleratorManagerWrapper 140 class UIAcceleratorManagerWrapper
139 : public AcceleratorManagerImpl::AcceleratorWrapper { 141 : public AcceleratorManagerImpl::AcceleratorWrapper {
140 public: 142 public:
141 UIAcceleratorManagerWrapper() 143 UIAcceleratorManagerWrapper()
142 : ui_accelerator_manager_(new ui::AcceleratorManager) {} 144 : ui_accelerator_manager_(new ui::AcceleratorManager) {}
143 ~UIAcceleratorManagerWrapper() override {} 145 ~UIAcceleratorManagerWrapper() override {}
144 146
145 virtual void Register(const ui::Accelerator& accelerator, 147 virtual void Register(const ui::Accelerator& accelerator,
146 ui::AcceleratorTarget* target) override { 148 ui::AcceleratorTarget* target) override {
147 ui_accelerator_manager_->Register( 149 ui_accelerator_manager_->Register(
148 accelerator, ui::AcceleratorManager::kNormalPriority, target); 150 accelerator, ui::AcceleratorManager::kNormalPriority, target);
149 } 151 }
150 152
151 virtual void Unregister(const ui::Accelerator& accelerator, 153 virtual void Unregister(const ui::Accelerator& accelerator,
152 ui::AcceleratorTarget* target) override { 154 ui::AcceleratorTarget* target) override {
153 ui_accelerator_manager_->Unregister(accelerator, target); 155 ui_accelerator_manager_->Unregister(accelerator, target);
154 } 156 }
155 157
156 virtual bool Process(const ui::Accelerator& accelerator) override { 158 virtual bool Process(const ui::Accelerator& accelerator) override {
157 return ui_accelerator_manager_->Process(accelerator); 159 return ui_accelerator_manager_->ProcessAccelerator(accelerator);
158 } 160 }
159 161
160 virtual ui::AcceleratorTarget* GetCurrentTarget( 162 virtual ui::AcceleratorTarget* GetCurrentTarget(
161 const ui::Accelerator& accelerator) const override { 163 const ui::Accelerator& accelerator) const override {
162 return ui_accelerator_manager_->GetCurrentTarget(accelerator); 164 return ui_accelerator_manager_->GetTargetForAccelerator(accelerator);
163 } 165 }
164 166
165 private: 167 private:
166 scoped_ptr<ui::AcceleratorManager> ui_accelerator_manager_; 168 scoped_ptr<ui::AcceleratorManager> ui_accelerator_manager_;
167 169
168 DISALLOW_COPY_AND_ASSIGN(UIAcceleratorManagerWrapper); 170 DISALLOW_COPY_AND_ASSIGN(UIAcceleratorManagerWrapper);
169 }; 171 };
170 172
171 class FocusManagerWrapper : public AcceleratorManagerImpl::AcceleratorWrapper { 173 class FocusManagerWrapper : public AcceleratorManagerImpl::AcceleratorWrapper {
172 public: 174 public:
(...skipping 12 matching lines...) Expand all
185 focus_manager_->UnregisterAccelerator(accelerator, target); 187 focus_manager_->UnregisterAccelerator(accelerator, target);
186 } 188 }
187 189
188 virtual bool Process(const ui::Accelerator& accelerator) override { 190 virtual bool Process(const ui::Accelerator& accelerator) override {
189 NOTREACHED(); 191 NOTREACHED();
190 return true; 192 return true;
191 } 193 }
192 194
193 virtual ui::AcceleratorTarget* GetCurrentTarget( 195 virtual ui::AcceleratorTarget* GetCurrentTarget(
194 const ui::Accelerator& accelerator) const override { 196 const ui::Accelerator& accelerator) const override {
195 return focus_manager_->GetCurrentTargetForAccelerator(accelerator); 197 return focus_manager_->GetTargetForAccelerator(accelerator);
196 } 198 }
197 199
198 private: 200 private:
199 views::FocusManager* focus_manager_; 201 views::FocusManager* focus_manager_;
200 202
201 DISALLOW_COPY_AND_ASSIGN(FocusManagerWrapper); 203 DISALLOW_COPY_AND_ASSIGN(FocusManagerWrapper);
202 }; 204 };
203 205
204 } // namespace 206 } // namespace
205 207
(...skipping 153 matching lines...) Expand 10 before | Expand all | Expand 10 after
359 return InputManager::Get()->GetAcceleratorManager(); 361 return InputManager::Get()->GetAcceleratorManager();
360 } 362 }
361 363
362 // static 364 // static
363 scoped_ptr<AcceleratorManager> AcceleratorManager::CreateForFocusManager( 365 scoped_ptr<AcceleratorManager> AcceleratorManager::CreateForFocusManager(
364 views::FocusManager* focus_manager) { 366 views::FocusManager* focus_manager) {
365 return AcceleratorManagerImpl::CreateForFocusManager(focus_manager).Pass(); 367 return AcceleratorManagerImpl::CreateForFocusManager(focus_manager).Pass();
366 } 368 }
367 369
368 } // namespace athena 370 } // namespace athena
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698