MacViews: Fix duplicate definition of ExtensionKeyBindingRegistry::SetShortcutHandlingSuspended

ash/accelerators/focus_manager_factory.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef ASH_ACCELERATORS_FOCUS_MANAGER_FACTORY_H_
 #define ASH_ACCELERATORS_FOCUS_MANAGER_FACTORY_H_
 
 #include "base/basictypes.h"
 #include "base/compiler_specific.h"
-#include "ui/views/focus/focus_manager_delegate.h"
+#include "ui/base/accelerators/accelerator.h"
 #include "ui/views/focus/focus_manager_factory.h"
 
 namespace ash {
 
 // A factory class for creating a custom views::FocusManager object which
 // supports Ash shortcuts.
-class AshFocusManagerFactory : public views::FocusManagerFactory {
+class AshFocusManagerFactory : public views::FocusManagerFactory,

[sky, 2015/01/08 23:39:25]

Having a class called FocusManagerFactory implement AcceleratorProcess is very
misleading. Can you follow a similar pattern to old and have the
AcceleratorProcess be implemented on a separate object that is handed to the
focus manager?

[Andre, 2015/01/09 00:06:15]

Done.
The asan builder was complaining that the object leaked, since the Delegate
object is never released
in the old pattern.

+                               public ui::AcceleratorProcessor {
  public:
   AshFocusManagerFactory();
   ~AshFocusManagerFactory() override;
 
+  // ui::AcceleratorProcessor overrides:
+  bool ProcessAccelerator(const ui::Accelerator& accelerator) override;
+  ui::AcceleratorTarget* GetTargetForAccelerator(
+      const ui::Accelerator& accelerator) const override;
+
  protected:
   // views::FocusManagerFactory overrides:
   views::FocusManager* CreateFocusManager(views::Widget* widget,
                                           bool desktop_widget) override;
 
  private:
-  class Delegate : public views::FocusManagerDelegate {
-   public:
-    // views::FocusManagerDelegate overrides:
-    bool ProcessAccelerator(const ui::Accelerator& accelerator) override;
-    ui::AcceleratorTarget* GetCurrentTargetForAccelerator(
-        const ui::Accelerator& accelerator) const override;
-  };
-
   DISALLOW_COPY_AND_ASSIGN(AshFocusManagerFactory);
 };
 
 }  // namespace ash
 
 #endif  // ASH_ACCELERATORS_FOCUS_MANAGER_FACTORY_H_