Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2553)

Unified Diff: editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/AnalysisOptions.java

Issue 838243004: Revert "Addition of the optional FileReadMode into the server spec." (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/FileReadMode.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/AnalysisOptions.java
diff --git a/editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/AnalysisOptions.java b/editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/AnalysisOptions.java
index 8ee1ccfbd9622bbe21634e6bbc8fcd4139cab4cb..89cb524f8f70200a1ea668e5d654eb63ad7d5aae 100644
--- a/editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/AnalysisOptions.java
+++ b/editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/AnalysisOptions.java
@@ -82,21 +82,15 @@ public class AnalysisOptions {
private final Boolean generateLints;
/**
- * The mode to read files from disk, by default this value is AS_IS.
- */
- private final String fileReadMode;
-
- /**
* Constructor for {@link AnalysisOptions}.
*/
- public AnalysisOptions(Boolean enableAsync, Boolean enableDeferredLoading, Boolean enableEnums, Boolean generateDart2jsHints, Boolean generateHints, Boolean generateLints, String fileReadMode) {
+ public AnalysisOptions(Boolean enableAsync, Boolean enableDeferredLoading, Boolean enableEnums, Boolean generateDart2jsHints, Boolean generateHints, Boolean generateLints) {
this.enableAsync = enableAsync;
this.enableDeferredLoading = enableDeferredLoading;
this.enableEnums = enableEnums;
this.generateDart2jsHints = generateDart2jsHints;
this.generateHints = generateHints;
this.generateLints = generateLints;
- this.fileReadMode = fileReadMode;
}
@Override
@@ -109,8 +103,7 @@ public class AnalysisOptions {
ObjectUtilities.equals(other.enableEnums, enableEnums) &&
ObjectUtilities.equals(other.generateDart2jsHints, generateDart2jsHints) &&
ObjectUtilities.equals(other.generateHints, generateHints) &&
- ObjectUtilities.equals(other.generateLints, generateLints) &&
- ObjectUtilities.equals(other.fileReadMode, fileReadMode);
+ ObjectUtilities.equals(other.generateLints, generateLints);
}
return false;
}
@@ -122,8 +115,7 @@ public class AnalysisOptions {
Boolean generateDart2jsHints = jsonObject.get("generateDart2jsHints") == null ? null : jsonObject.get("generateDart2jsHints").getAsBoolean();
Boolean generateHints = jsonObject.get("generateHints") == null ? null : jsonObject.get("generateHints").getAsBoolean();
Boolean generateLints = jsonObject.get("generateLints") == null ? null : jsonObject.get("generateLints").getAsBoolean();
- String fileReadMode = jsonObject.get("fileReadMode") == null ? null : jsonObject.get("fileReadMode").getAsString();
- return new AnalysisOptions(enableAsync, enableDeferredLoading, enableEnums, generateDart2jsHints, generateHints, generateLints, fileReadMode);
+ return new AnalysisOptions(enableAsync, enableDeferredLoading, enableEnums, generateDart2jsHints, generateHints, generateLints);
}
public static List<AnalysisOptions> fromJsonArray(JsonArray jsonArray) {
@@ -166,13 +158,6 @@ public class AnalysisOptions {
}
/**
- * The mode to read files from disk, by default this value is AS_IS.
- */
- public String getFileReadMode() {
- return fileReadMode;
- }
-
- /**
* True if hints that are specific to dart2js should be generated. This option is ignored if
* generateHints is false.
*/
@@ -203,7 +188,6 @@ public class AnalysisOptions {
builder.append(generateDart2jsHints);
builder.append(generateHints);
builder.append(generateLints);
- builder.append(fileReadMode);
return builder.toHashCode();
}
@@ -227,9 +211,6 @@ public class AnalysisOptions {
if (generateLints != null) {
jsonObject.addProperty("generateLints", generateLints);
}
- if (fileReadMode != null) {
- jsonObject.addProperty("fileReadMode", fileReadMode);
- }
return jsonObject;
}
@@ -248,9 +229,7 @@ public class AnalysisOptions {
builder.append("generateHints=");
builder.append(generateHints + ", ");
builder.append("generateLints=");
- builder.append(generateLints + ", ");
- builder.append("fileReadMode=");
- builder.append(fileReadMode);
+ builder.append(generateLints);
builder.append("]");
return builder.toString();
}
« no previous file with comments | « no previous file | editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/FileReadMode.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698