net: Remove unused private data members

net: Remove unused private data members

These unused members were found by locally changing DISALLOW_COPY_AND_ASSIGN to use "= delete"
so that the compiler can be sure these members are not used in the copy ctor and operator=.

BUG=447445
TEST=build

Committed: https://crrev.com/0d3e4fbd7d604683d977a9a6dc0a8f4f31f53047
Cr-Commit-Position: refs/heads/master@{#310712}

[hashimoto, 2015-01-08 11:10:37]

hashimoto@chromium.org changed reviewers:
+ mmenke@chromium.org

[mmenke, 2015-01-08 17:37:56]

LGTM.  Thanks for doing this - a check for unused members shounds handy!  I
think you should file a separate bug for getting rid of unused members, though,
as this really doesn't have much to do with the filed bug (Use "= delete" to
implement DISALLOW_COPY_AND_ASSIGN).

https://codereview.chromium.org/838203002/diff/1/net/http/http_proxy_client_s...
File net/http/http_proxy_client_socket_pool.cc (right):

https://codereview.chromium.org/838203002/diff/1/net/http/http_proxy_client_s...
net/http/http_proxy_client_socket_pool.cc:446: const ProxyDelegate*
proxy_delegate,
Think you can go ahead and remove this, too.

[hashimoto, 2015-01-09 02:08:45]

Filed a new issue http://crbug.com/447445 for unused member removal.

https://codereview.chromium.org/838203002/diff/1/net/http/http_proxy_client_s...
File net/http/http_proxy_client_socket_pool.cc (right):

https://codereview.chromium.org/838203002/diff/1/net/http/http_proxy_client_s...
net/http/http_proxy_client_socket_pool.cc:446: const ProxyDelegate*
proxy_delegate,
On 2015/01/08 17:37:55, mmenke wrote:
> Think you can go ahead and remove this, too.

Thanks,
This also resulted in removing proxy_delegate from ClientSocketPoolManagerImpl.

[hashimoto, 2015-01-09 02:08:52]

The CQ bit was checked by hashimoto@chromium.org

[commit-bot: I haz the power, 2015-01-09 02:09:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/838203002/20001

[hashimoto, 2015-01-09 02:31:39]

iOS is failing because of the thread check.
Added a DetachFromThread() call to fix this.

[hashimoto, 2015-01-09 04:05:15]

Patchset #4 (id:60001) has been deleted

[hashimoto, 2015-01-09 04:07:40]

Gave up enabling the thread check in URLRequestJobManager.
Reverted the "#if 0" block to keep the comments for future reference.

Probably, what we should do is just removing IsAllowedThread() as the bug
referenced in the comment (http://b/issue?id=1338969) was already closed as
WontFix.

[hashimoto, 2015-01-09 04:07:45]

The CQ bit was checked by hashimoto@chromium.org

[commit-bot: I haz the power, 2015-01-09 04:08:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/838203002/80001

[mmenke, 2015-01-09 04:19:06]

On 2015/01/09 04:07:40, hashimoto wrote:
> Gave up enabling the thread check in URLRequestJobManager.
> Reverted the "#if 0" block to keep the comments for future reference.
> 
> Probably, what we should do is just removing IsAllowedThread() as the bug
> referenced in the comment (http://b/issue?id=1338969) was already closed as
> WontFix.

The JobManager isn't long for this world, anyways...We're in the (slow) process
of getting rid of it.

[hashimoto, 2015-01-09 04:58:43]

On 2015/01/09 04:19:06, mmenke wrote:
> On 2015/01/09 04:07:40, hashimoto wrote:
> > Gave up enabling the thread check in URLRequestJobManager.
> > Reverted the "#if 0" block to keep the comments for future reference.
> > 
> > Probably, what we should do is just removing IsAllowedThread() as the bug
> > referenced in the comment (http://b/issue?id=1338969) was already closed as
> > WontFix.
> 
> The JobManager isn't long for this world, anyways...We're in the (slow)
process
> of getting rid of it.

Thanks, relieved to hear that.

[commit-bot: I haz the power, 2015-01-09 05:03:20]

Committed patchset #4 (id:80001)

[commit-bot: I haz the power, 2015-01-09 05:04:15]

Patchset 4 (id:??) landed as
https://crrev.com/0d3e4fbd7d604683d977a9a6dc0a8f4f31f53047
Cr-Commit-Position: refs/heads/master@{#310712}