Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issue 838193002: Fix CrOS FileManagerBrowserTest with scheduler enabled (Closed)

Created:
5 years, 11 months ago by alex clarke (OOO till 29th)
Modified:
5 years, 11 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, scheduler-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix CrOS FileManagerBrowserTest with scheduler enabled The timeouts in OpenAudioFiles/FileManagerBrowserTest where due to a task reordering which caused audioPlayerApp.closeWindowAndWait to never complete because the call to getWindows failed silently. Patches 837203002 and 832183008 must be submitted first. BUG=432129, 444574 Committed: https://crrev.com/e19d4ef3a1fd8d287ea198b1bf37241d2046a1cc Cr-Commit-Position: refs/heads/master@{#310791}

Patch Set 1 #

Patch Set 2 : Turns out MockRenderThread::GetTaskRunner needs to return a real task runner. #

Patch Set 3 : Fix TestAsNormalAndGuestUser/SpokenFeedbackTest #

Patch Set 4 : Split into smaller patch #

Patch Set 5 : Don't need change to renderer_accessibility.cc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M content/public/test/mock_render_thread.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_widget.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 26 (10 generated)
alex clarke (OOO till 29th)
5 years, 11 months ago (2015-01-08 10:34:23 UTC) #2
alex clarke (OOO till 29th)
5 years, 11 months ago (2015-01-08 10:34:46 UTC) #4
alex clarke (OOO till 29th)
5 years, 11 months ago (2015-01-08 10:59:55 UTC) #6
Sami
lgtm once the other patches are in.
5 years, 11 months ago (2015-01-08 11:33:31 UTC) #7
jochen (gone - plz use gerrit)
lgtm
5 years, 11 months ago (2015-01-08 13:11:36 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/838193002/1
5 years, 11 months ago (2015-01-09 10:28:51 UTC) #10
alex clarke (OOO till 29th)
I had to change MockRenderThread::GetTaskRunner since this patch was failing on some bots.
5 years, 11 months ago (2015-01-09 11:58:53 UTC) #12
Sami
lgtm.
5 years, 11 months ago (2015-01-09 12:27:48 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/838193002/20001
5 years, 11 months ago (2015-01-09 12:30:12 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/13231)
5 years, 11 months ago (2015-01-09 13:55:11 UTC) #17
alex clarke (OOO till 29th)
As discussed offline (with Sami) I've reduced the scope of this patch. it just fixes ...
5 years, 11 months ago (2015-01-09 14:54:38 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/838193002/60001
5 years, 11 months ago (2015-01-09 14:55:57 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_tests_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tests_recipe/builds/43634)
5 years, 11 months ago (2015-01-09 16:36:49 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/838193002/80001
5 years, 11 months ago (2015-01-09 16:57:48 UTC) #24
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 11 months ago (2015-01-09 17:46:09 UTC) #25
commit-bot: I haz the power
5 years, 11 months ago (2015-01-09 17:46:57 UTC) #26
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/e19d4ef3a1fd8d287ea198b1bf37241d2046a1cc
Cr-Commit-Position: refs/heads/master@{#310791}

Powered by Google App Engine
This is Rietveld 408576698