Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(583)

Issue 83813003: Cleanup of page_measurement_results object (Closed)

Created:
7 years, 1 month ago by nduca
Modified:
7 years, 1 month ago
Reviewers:
tonyg
CC:
chromium-reviews, chrome-speed-team+watch_google.com, telemetry+watch_chromium.org
Visibility:
Public.

Description

Cleanup of page_measurement_results object This patch introduces telemetry.value, which factors out the different kinds of data collected by telemetry benchmarks, currently scalar values, lists of scalar values, and histograms. This factoring provides mechanisms for combining together values --- value summarization, which was previously the job of the results objects, is now part of the value system. The actual interface between the page_measurement_results object and the rest of telemetry is unchanged. A values_backcompat module exists to convert the old interface to the new interface. A followup patch can remove this backcompat path. Most discussion of this is on https://codereview.chromium.org/27486002/ BUG=306944 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=236907

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1837 lines, -559 lines) Patch
M tools/perf/benchmarks/dom_perf.py View 2 chunks +6 lines, -4 lines 0 comments Download
M tools/perf/benchmarks/peacekeeper.py View 3 chunks +6 lines, -6 lines 0 comments Download
M tools/perf/measurements/page_cycler_unittest.py View 1 chunk +11 lines, -9 lines 0 comments Download
M tools/perf/metrics/smoothness_unittest.py View 1 chunk +13 lines, -5 lines 0 comments Download
M tools/telemetry/telemetry/page/block_page_measurement_results.py View 1 chunk +6 lines, -11 lines 0 comments Download
M tools/telemetry/telemetry/page/buildbot_page_measurement_results.py View 3 chunks +139 lines, -92 lines 0 comments Download
M tools/telemetry/telemetry/page/buildbot_page_measurement_results_unittest.py View 15 chunks +163 lines, -50 lines 0 comments Download
M tools/telemetry/telemetry/page/csv_page_measurement_results.py View 4 chunks +41 lines, -26 lines 0 comments Download
M tools/telemetry/telemetry/page/csv_page_measurement_results_unittest.py View 3 chunks +17 lines, -17 lines 0 comments Download
M tools/telemetry/telemetry/page/html_page_measurement_results.py View 3 chunks +16 lines, -10 lines 0 comments Download
M tools/telemetry/telemetry/page/html_page_measurement_results_unittest.py View 3 chunks +162 lines, -160 lines 0 comments Download
M tools/telemetry/telemetry/page/page.py View 1 chunk +9 lines, -0 lines 0 comments Download
M tools/telemetry/telemetry/page/page_measurement_results.py View 1 chunk +79 lines, -88 lines 0 comments Download
M tools/telemetry/telemetry/page/page_measurement_results_unittest.py View 2 chunks +115 lines, -47 lines 0 comments Download
M tools/telemetry/telemetry/page/page_measurement_unittest.py View 1 chunk +2 lines, -2 lines 0 comments Download
D tools/telemetry/telemetry/page/page_measurement_value.py View 1 chunk +0 lines, -32 lines 0 comments Download
M tools/telemetry/telemetry/page/page_test_results.py View 2 chunks +9 lines, -0 lines 0 comments Download
A tools/telemetry/telemetry/page/page_test_results_unittest.py View 1 chunk +67 lines, -0 lines 0 comments Download
M tools/telemetry/telemetry/page/page_unittest.py View 1 chunk +14 lines, -0 lines 0 comments Download
A tools/telemetry/telemetry/value/__init__.py View 1 chunk +182 lines, -0 lines 0 comments Download
A tools/telemetry/telemetry/value/histogram.py View 1 chunk +97 lines, -0 lines 0 comments Download
A tools/telemetry/telemetry/value/histogram_unittest.py View 1 chunk +49 lines, -0 lines 0 comments Download
A tools/telemetry/telemetry/value/list_of_scalar_values.py View 1 chunk +93 lines, -0 lines 0 comments Download
A tools/telemetry/telemetry/value/list_of_scalar_values_unittest.py View 1 chunk +80 lines, -0 lines 0 comments Download
A tools/telemetry/telemetry/value/merge_values.py View 1 chunk +116 lines, -0 lines 0 comments Download
A tools/telemetry/telemetry/value/merge_values_unittest.py View 1 chunk +118 lines, -0 lines 0 comments Download
A tools/telemetry/telemetry/value/scalar.py View 1 chunk +67 lines, -0 lines 0 comments Download
A tools/telemetry/telemetry/value/scalar_unittest.py View 1 chunk +66 lines, -0 lines 0 comments Download
A tools/telemetry/telemetry/value/value_backcompat.py View 1 chunk +46 lines, -0 lines 0 comments Download
A tools/telemetry/telemetry/value/value_unittest_.py View 1 chunk +48 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
tonyg
lgtm giddyup :)
7 years, 1 month ago (2013-11-22 22:08:07 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nduca@chromium.org/83813003/1
7 years, 1 month ago (2013-11-22 22:16:33 UTC) #2
commit-bot: I haz the power
7 years, 1 month ago (2013-11-23 01:37:08 UTC) #3
Message was sent while issue was closed.
Change committed as 236907

Powered by Google App Engine
This is Rietveld 408576698