Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 838113003: Update net/data/websocket/OWNERS to include active developers (Closed)

Created:
5 years, 11 months ago by tyoshino (SeeGerritForStatus)
Modified:
5 years, 11 months ago
Reviewers:
Takashi Toyoshima
CC:
chromium-reviews, cbentzel+watch_chromium.org, mmenke, yhirano, Adam Rice
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update net/data/websocket/OWNERS to include active developers R=toyoshim NOTRY=true BUG=none Committed: https://crrev.com/936c15cd4eeedd04873491a4799a36a10a622a3a Cr-Commit-Position: refs/heads/master@{#311409}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed #3 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M net/data/websocket/OWNERS View 1 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
tyoshino (SeeGerritForStatus)
Toyoshima-san, please review. CC: mmenke, yhirano, ricea
5 years, 11 months ago (2015-01-08 07:58:31 UTC) #2
Takashi Toyoshima
LGTM https://codereview.chromium.org/838113003/diff/1/net/data/websocket/OWNERS File net/data/websocket/OWNERS (right): https://codereview.chromium.org/838113003/diff/1/net/data/websocket/OWNERS#newcode1 net/data/websocket/OWNERS:1: tyoshino@chromium.org Just in case: If there is no ...
5 years, 11 months ago (2015-01-08 10:55:46 UTC) #3
tyoshino (SeeGerritForStatus)
https://codereview.chromium.org/838113003/diff/1/net/data/websocket/OWNERS File net/data/websocket/OWNERS (right): https://codereview.chromium.org/838113003/diff/1/net/data/websocket/OWNERS#newcode1 net/data/websocket/OWNERS:1: tyoshino@chromium.org On 2015/01/08 10:55:46, Takashi Toyoshima (chromium) wrote: > ...
5 years, 11 months ago (2015-01-14 04:39:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/838113003/20001
5 years, 11 months ago (2015-01-14 04:39:30 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-14 04:40:16 UTC) #7
commit-bot: I haz the power
5 years, 11 months ago (2015-01-14 04:41:04 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/936c15cd4eeedd04873491a4799a36a10a622a3a
Cr-Commit-Position: refs/heads/master@{#311409}

Powered by Google App Engine
This is Rietveld 408576698