Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(411)

Issue 838103002: Fix for #US#US issue in inprocess PDF case. (Closed)

Created:
5 years, 11 months ago by Deepak
Modified:
5 years, 11 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix for #US#US issue in inprocess PDF case. Now old '#' is searched and replaced by the new #XXX string. This is fix for 445184 issue for In process case. BUG=445184 Committed: https://crrev.com/55b67c0f2d850283e08b89e80751719ecb42b0f6 Cr-Commit-Position: refs/heads/master@{#310496}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Addressing nit. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M pdf/instance.cc View 1 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 16 (6 generated)
Deepak
This is #US#US issue fix for in process case. PTAL.
5 years, 11 months ago (2015-01-08 04:52:20 UTC) #2
Lei Zhang
lgtm https://codereview.chromium.org/838103002/diff/1/pdf/instance.cc File pdf/instance.cc (right): https://codereview.chromium.org/838103002/diff/1/pdf/instance.cc#newcode1229 pdf/instance.cc:1229: // if '#' is already present in |url_| ...
5 years, 11 months ago (2015-01-08 04:55:54 UTC) #3
Deepak
On 2015/01/08 04:55:54, Lei Zhang wrote: > lgtm > > https://codereview.chromium.org/838103002/diff/1/pdf/instance.cc > File pdf/instance.cc (right): ...
5 years, 11 months ago (2015-01-08 05:00:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/838103002/20001
5 years, 11 months ago (2015-01-08 05:01:33 UTC) #6
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
5 years, 11 months ago (2015-01-08 07:03:01 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/838103002/20001
5 years, 11 months ago (2015-01-08 07:23:11 UTC) #10
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
5 years, 11 months ago (2015-01-08 09:24:23 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/838103002/20001
5 years, 11 months ago (2015-01-08 13:43:10 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-08 14:08:09 UTC) #15
commit-bot: I haz the power
5 years, 11 months ago (2015-01-08 14:08:58 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/55b67c0f2d850283e08b89e80751719ecb42b0f6
Cr-Commit-Position: refs/heads/master@{#310496}

Powered by Google App Engine
This is Rietveld 408576698