Add OnLegacySessionError() in CDM_7.

Add OnLegacySessionError() in CDM_7.

This method is to support existing prefixed EME API, where key related errors need to be reported explicitly. This method will NOT be used by prefixed EME.

When we deprecate prefixed EME, this should be removed.

BUG=428384
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=293568

[xhwang, 2015-01-08 02:02:13]

xhwang@chromium.org changed reviewers:
+ ddorwin@chromium.org, jrummell@chromium.org

[xhwang, 2015-01-08 02:02:14]

PTAL

[ddorwin, 2015-01-08 03:09:33]

Thanks! LGTM % nits. Perhaps also explain why it's being added in the CL
description.

https://codereview.chromium.org/838063002/diff/20001/content_decryption_module.h
File content_decryption_module.h (right):

https://codereview.chromium.org/838063002/diff/20001/content_decryption_modul...
content_decryption_module.h:1038: // termination. This method is only for
supporting legacy prefixed API.
nit suggestions:
* New line for last method.
* "...supporting the prefixed EME API."
* Specifically note that all such errors should probably be reported by one of
the other methods too and that this method will be ignored for unprefixed EME.

[jrummell, 2015-01-08 03:54:19]

lgtm

[xhwang, 2015-01-08 03:54:43]

comments addressed

[xhwang, 2015-01-08 03:54:53]

https://codereview.chromium.org/838063002/diff/20001/content_decryption_module.h
File content_decryption_module.h (right):

https://codereview.chromium.org/838063002/diff/20001/content_decryption_modul...
content_decryption_module.h:1038: // termination. This method is only for
supporting legacy prefixed API.
On 2015/01/08 03:09:32, ddorwin wrote:
> nit suggestions:
> * New line for last method.
> * "...supporting the prefixed EME API."
> * Specifically note that all such errors should probably be reported by one of
> the other methods too and that this method will be ignored for unprefixed EME.

Done.

[ddorwin, 2015-01-08 04:23:51]

LGTM.

Please update the description per my earlier comment. Thanks!

[xhwang, 2015-01-08 04:26:53]

The CQ bit was checked by xhwang@chromium.org

[commit-bot: I haz the power, 2015-01-08 04:27:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/838063002/40001

[xhwang, 2015-01-08 04:27:07]

The CQ bit was unchecked by xhwang@chromium.org

[commit-bot: I haz the power, 2015-01-08 04:27:19]

The CQ bit was unchecked by commit-bot@chromium.org

[xhwang, 2015-01-08 04:33:08]

The CQ bit was checked by xhwang@chromium.org

[commit-bot: I haz the power, 2015-01-08 04:34:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/838063002/40001

[commit-bot: I haz the power, 2015-01-08 04:34:19]

Committed patchset #3 (id:40001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=293568