Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 838023003: Clear the cancel callback before calling it. (Closed)

Created:
5 years, 11 months ago by mtomasz
Modified:
5 years, 11 months ago
Reviewers:
hirono
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clear the cancel callback before calling it. As the completion callback is called externally it should be cleared first, to avoid possible double cancellation. TEST=None BUG=None Committed: https://crrev.com/41d8d3c2026d46f860694dc0fc51e61543be8adf Cr-Commit-Position: refs/heads/master@{#311422}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M ui/file_manager/file_manager/background/js/file_operation_util.js View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
mtomasz
@hirono: PTAL. Thanks.
5 years, 11 months ago (2015-01-14 06:33:17 UTC) #2
hirono
lgtm!
5 years, 11 months ago (2015-01-14 06:39:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/838023003/1
5 years, 11 months ago (2015-01-14 06:53:09 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-14 06:55:07 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-14 06:55:58 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/41d8d3c2026d46f860694dc0fc51e61543be8adf
Cr-Commit-Position: refs/heads/master@{#311422}

Powered by Google App Engine
This is Rietveld 408576698