Issue 838003008: Get rid of ensureStyleResolver().

Issue 838003008: Get rid of ensureStyleResolver(). (Closed)

Created:
5 years, 11 months ago by esprehn

Modified:
5 years, 11 months ago

Reviewers:
jamesr, ojan

CC:
ojan, abarth-chromium, mojo-reviews_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Get rid of ensureStyleResolver(). It doesn't have side effects anymore, and active documents always have a StyleResolver. R=ojan@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/504bc9be0fdc8ba4894cbf273f0897767c8fcaa0

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+19 lines, -45 lines)			Patch
M	sky/engine/core/css/FontFaceSet.cpp	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	sky/engine/core/css/resolver/ScopedStyleResolver.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sky/engine/core/dom/Document.h	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	sky/engine/core/dom/Document.cpp	View	5 chunks	+6 lines, -13 lines	0 comments	Download
M	sky/engine/core/dom/Element.cpp	View	10 chunks	+6 lines, -21 lines	0 comments	Download
M	sky/engine/core/dom/StyleEngine.cpp	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	sky/engine/core/dom/Text.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sky/engine/core/frame/FrameView.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sky/engine/core/html/canvas/CanvasRenderingContext2D.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 6 (2 generated)

esprehn

Committed patchset #1 (id:1) manually as 504bc9be0fdc8ba4894cbf273f0897767c8fcaa0 (presubmit successful).

5 years, 11 months ago (2015-01-17 01:49:36 UTC) #4

jamesr

5 years, 11 months ago (2015-01-17 02:34:41 UTC) #6

Message was sent while issue was closed.

This patch doesn't compile on most bots. Please use the trybots, they're really
fast.