Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Issue 838003006: Add use counters for Fetch API. (Closed)

Created:
5 years, 11 months ago by yhirano
Modified:
5 years, 11 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Add use counters for Fetch API. This CL adds two use counters: Fetch and FetchBodyStream. Fetch counts the number of fetch() function calls. FetchBodyStream is logged when .body attribute is accessed in Body mixin. Note that both events in SharedWorker and ServiceWorker are not counted. BUG=436770, 435393 R=tyoshino Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188602

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M Source/core/frame/UseCounter.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M Source/modules/fetch/Body.cpp View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/modules/fetch/GlobalFetch.cpp View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
yhirano
5 years, 11 months ago (2015-01-16 11:13:43 UTC) #1
tyoshino (SeeGerritForStatus)
lgtm
5 years, 11 months ago (2015-01-19 05:23:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/838003006/1
5 years, 11 months ago (2015-01-19 05:26:03 UTC) #4
commit-bot: I haz the power
Failed to apply patch for Source/core/frame/UseCounter.h: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
5 years, 11 months ago (2015-01-19 05:26:12 UTC) #6
yhirano
+kouhei for core/UseCounter.h
5 years, 11 months ago (2015-01-19 06:05:04 UTC) #8
kouhei (in TOK)
lgtm. Don't forget to run tools/metrics/histograms/update_use_counter_feature_enum.py
5 years, 11 months ago (2015-01-19 06:20:03 UTC) #9
yhirano
On 2015/01/19 06:20:03, kouhei wrote: > lgtm. Don't forget to run > tools/metrics/histograms/update_use_counter_feature_enum.py Thanks! I ...
5 years, 11 months ago (2015-01-19 06:22:41 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/838003006/20001
5 years, 11 months ago (2015-01-19 06:23:38 UTC) #12
commit-bot: I haz the power
5 years, 11 months ago (2015-01-19 08:10:02 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=188602

Powered by Google App Engine
This is Rietveld 408576698