appengine/findit/waterfall/extractors.py - Issue 838003004: [Findit] Add three sub-pipelines to analyze build failure.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: appengine/findit/waterfall/extractors.py

Issue 838003004: [Findit] Add three sub-pipelines to analyze build failure. (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master

Patch Set: Address comments. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« appengine/findit/waterfall/build_failure_analysis.py ('K') | « appengine/findit/waterfall/extractor_util.py ('k') | appengine/findit/waterfall/identify_culprit_pipeline.py » ('j') | appengine/findit/waterfall/identify_culprit_pipeline.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: appengine/findit/waterfall/extractors.py

diff --git a/appengine/findit/waterfall/extractors.py b/appengine/findit/waterfall/extractors.py

index 3c3f463aebbad63a09530cccd03f28cb6332c5e8..015f02312bf4bf931f27f2437104ef85b7b2b6bf 100644

--- a/appengine/findit/waterfall/extractors.py

+++ b/appengine/findit/waterfall/extractors.py

@@ -1,4 +1,4 @@

# Use of this source code is governed by a BSD-style license that can be

# found in the LICENSE file.

@@ -79,4 +79,4 @@ def ExtractSignal(master_name, bot_name, step_name, test_name, failure_log):

# Fall back to a general-but-maybe-not-accurate extractor.

extractor_class = EXTRACTORS.get(step_name, GeneralExtractor)

return extractor_class().Extract(

- master_name, bot_name, step_name, test_name, failure_log)

+ failure_log, test_name, step_name, bot_name, master_name)