appengine/findit/common/git_repository.py - Issue 838003004: [Findit] Add three sub-pipelines to analyze build failure.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: appengine/findit/common/git_repository.py

Issue 838003004: [Findit] Add three sub-pipelines to analyze build failure. (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master

Patch Set: Address comments. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: appengine/findit/common/git_repository.py

diff --git a/appengine/findit/common/git_repository.py b/appengine/findit/common/git_repository.py

index 0265729f1ea73223898f803cf9f1e9bf529a8cc3..e227945b7ba5523ee75a324b435153b32739e749 100644

--- a/appengine/findit/common/git_repository.py

+++ b/appengine/findit/common/git_repository.py

@@ -59,7 +59,10 @@ def NormalizeEmail(email):

Some email is like: person@@chromium.org@bbb929c8-8fbe-4397-9dbb-9b2b20218538.

qyearsley 2015/01/16 22:55:25 In the test, you have an example that looks like "

stgao 2015/01/21 20:29:22 Good catch. Typo was corrected.

"""

parts = email.split('@')

- return '@'.join(parts[:-1])

+ if len(parts) > 2:

+ return '@'.join(parts[0:2])

+ else:

+ return email

class GitRepository(Repository):

« no previous file with comments | « no previous file | appengine/findit/common/test/git_repository_test.py » ('j') | appengine/findit/waterfall/build_failure_analysis.py » ('J')