appengine/findit/waterfall/extractor_util.py - Issue 838003004: [Findit] Add three sub-pipelines to analyze build failure.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: appengine/findit/waterfall/extractor_util.py

Issue 838003004: [Findit] Add three sub-pipelines to analyze build failure. (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master

Patch Set: Address comments. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« appengine/findit/waterfall/build_failure_analysis.py ('K') | « appengine/findit/waterfall/extractor.py ('k') | appengine/findit/waterfall/extractors.py » ('j') | appengine/findit/waterfall/identify_culprit_pipeline.py » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 # Copyright (c) 2014 The Chromium Authors. All rights reserved.	1 # Copyright 2014 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 import re	5 import re

6	6

7	7

8 # File extensions to filter out files from log.	8 # File extensions to filter out files from log.

9 SUPPORTED_FILE_EXTENSIONS = [	9 SUPPORTED_FILE_EXTENSIONS = [

10 'c',	10 'c',

11 'cc',	11 'cc',

(...skipping 125 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
137 """Return True if the given line from failure log should be ignored.	137 """Return True if the given line from failure log should be ignored.

138	138

139 Some non-fatal logging messages include a file name and line number, but they	139 Some non-fatal logging messages include a file name and line number, but they

140 are not related to the failure at all and could lead to false positive.	140 are not related to the failure at all and could lead to false positive.

141 """	141 """

142 # TODO: log of ERROR level should be taken care of?	142 # TODO: log of ERROR level should be taken care of?

143 for log_level in ('INFO:', 'WARNING:', 'ERROR:'):	143 for log_level in ('INFO:', 'WARNING:', 'ERROR:'):

144 if log_level in line:	144 if log_level in line:

145 return True	145 return True

146 return False	146 return False

OLD	NEW