Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issue 838003003: Adding missing include for base/bind.h (Closed)

Created:
5 years, 11 months ago by Daniel Bratell
Modified:
5 years, 11 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adding missing include for base/bind.h This code uses base::Bind and in default configurations "base/bind.h" is included through chrome/browser/extensions/extension_service.h -> chrome/browser/extensions/blacklist.h -> chrome/browser/safe_browsing/database_manager.h -> chrome/browser/safe_browsing/protocol_manager.h -> ... but in my configuration the code needs to be good code and include headers for code it uses itself. BUG= Committed: https://crrev.com/7bc7846ce63fc60f2c87b279c3a506c76c2a5323 Cr-Commit-Position: refs/heads/master@{#310549}

Patch Set 1 #

Total comments: 2

Patch Set 2 : And bind_helpers.h #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chrome/browser/extensions/shared_module_service.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Daniel Bratell
Please take a look.
5 years, 11 months ago (2015-01-08 16:36:29 UTC) #2
Devlin
https://codereview.chromium.org/838003003/diff/1/chrome/browser/extensions/shared_module_service.cc File chrome/browser/extensions/shared_module_service.cc (right): https://codereview.chromium.org/838003003/diff/1/chrome/browser/extensions/shared_module_service.cc#newcode10 chrome/browser/extensions/shared_module_service.cc:10: #include "base/bind.h" Since you're adding this one, wanna go ...
5 years, 11 months ago (2015-01-08 16:43:49 UTC) #3
Daniel Bratell
Absolutely! I even removed it from an earlier version because I didn't understand that DoNothing ...
5 years, 11 months ago (2015-01-08 16:54:50 UTC) #4
Devlin
On 2015/01/08 16:54:50, Daniel Bratell wrote: > Absolutely! I even removed it from an earlier ...
5 years, 11 months ago (2015-01-08 16:55:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/838003003/20001
5 years, 11 months ago (2015-01-08 16:59:14 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-08 18:56:27 UTC) #8
commit-bot: I haz the power
5 years, 11 months ago (2015-01-08 18:57:14 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7bc7846ce63fc60f2c87b279c3a506c76c2a5323
Cr-Commit-Position: refs/heads/master@{#310549}

Powered by Google App Engine
This is Rietveld 408576698