Convert the inspector framework to use ES6 classes.

Convert the inspector framework to use ES6 classes.

BUG=
R=esprehn@chromium.org

Committed: https://chromium.googlesource.com/external/mojo/+/77c9901f5eeaa9b4f4977cc5a1960d8b5bd1b2a8

[tonyg, 2015-01-14 01:19:31]

tonyg@chromium.org changed reviewers:
+ eseidel@chromium.org

[esprehn, 2015-01-14 02:03:21]

esprehn@chromium.org changed reviewers:
+ esprehn@chromium.org

[esprehn, 2015-01-14 02:03:22]

Lets add a constructor() to all the classes, and put
Object.preventExtensions(this) as the last statement in each constructor. This
prevents anyone from adding expandos which makes code slow, and also catches
property name typos earlier.

https://codereview.chromium.org/837933003/diff/20001/sky/framework/inspector/...
File sky/framework/inspector/css-agent.sky (right):

https://codereview.chromium.org/837933003/diff/20001/sky/framework/inspector/...
sky/framework/inspector/css-agent.sky:4: this.domAgent_ = domAgent;
Object.preventExtensions(this);

[tonyg, 2015-01-14 02:44:38]

On 2015/01/14 02:03:22, esprehn wrote:
> Lets add a constructor() to all the classes, and put
> Object.preventExtensions(this) as the last statement in each constructor. This
> prevents anyone from adding expandos which makes code slow, and also catches
> property name typos earlier.

Done.

We need a "final" keyword ;)

[esprehn, 2015-01-14 02:46:12]

lgtm, final would be amazing.

[tonyg, 2015-01-14 02:49:55]

Committed patchset #3 (id:40001) manually as
77c9901f5eeaa9b4f4977cc5a1960d8b5bd1b2a8 (presubmit successful).

[jamesr, 2015-01-14 18:48:59]

jamesr@chromium.org changed reviewers:
+ jamesr@chromium.org

[jamesr, 2015-01-14 18:49:00]

This patch appears to break these tests:

Regressions: Unexpected timeouts (2)
  inspector/dom-mutation-modify-text-node-and-append.sky [ Timeout ]
  inspector/dom-mutation.sky [ Timeout ]

currently the waterfall is configured to show sky failures as green