Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Unified Diff: editor/tools/plugins/com.google.dart.engine.services/src/com/google/dart/engine/services/completion/CompletionEngine.java

Issue 83793016: Issue 13549. Tweaks for arguments list completion. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: editor/tools/plugins/com.google.dart.engine.services/src/com/google/dart/engine/services/completion/CompletionEngine.java
diff --git a/editor/tools/plugins/com.google.dart.engine.services/src/com/google/dart/engine/services/completion/CompletionEngine.java b/editor/tools/plugins/com.google.dart.engine.services/src/com/google/dart/engine/services/completion/CompletionEngine.java
index e30f42ee234cc033812b80dca24361156a4a6cd9..2aa080b9aa9e30ee8e4d5e6f1725e0c41900080d 100644
--- a/editor/tools/plugins/com.google.dart.engine.services/src/com/google/dart/engine/services/completion/CompletionEngine.java
+++ b/editor/tools/plugins/com.google.dart.engine.services/src/com/google/dart/engine/services/completion/CompletionEngine.java
@@ -13,6 +13,7 @@
*/
package com.google.dart.engine.services.completion;
+import com.google.common.base.Objects;
import com.google.common.collect.Lists;
import com.google.common.collect.Sets;
import com.google.dart.engine.ast.ASTNode;
@@ -823,7 +824,9 @@ public class CompletionEngine {
int offset = methodName.getOffset();
int len = node.getRightParenthesis().getEnd() - offset;
for (CompletionProposal proposal : proposalRequestor.getProposals()) {
- pArgumentList(proposal, offset, len);
+ if (Objects.equal(proposal.getElement(), invokeNode.getStaticElement())) {
+ pArgumentList(proposal, offset, len);
+ }
}
}
analyzeLocalName(new Ident(node));
@@ -2372,9 +2375,16 @@ public class CompletionEngine {
}
private void pArgumentList(CompletionProposal proposal, int offset, int len) {
+ // prepare parameters
+ String[] parameterNames = proposal.getParameterNames();
+ if (parameterNames.length == 0) {
+ return;
+ }
+ // fill arguments proposal
CompletionProposal prop = createProposal(ProposalKind.ARGUMENT_LIST);
+ prop.setElement(proposal.getElement());
prop.setCompletion(proposal.getCompletion()).setReturnType(proposal.getReturnType());
- prop.setParameterNames(proposal.getParameterNames());
+ prop.setParameterNames(parameterNames);
prop.setParameterTypes(proposal.getParameterTypes());
prop.setParameterStyle(
proposal.getPositionalParameterCount(),
« no previous file with comments | « no previous file | editor/tools/plugins/com.google.dart.engine.services_test/src/com/google/dart/engine/services/completion/CompletionTests.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698