Issue 83793013: Fix media metrics report float values post crrev.com/84483002

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 83793013: Fix media metrics report float values post crrev.com/84483002 (Closed)

Created:
7 years ago by shadi

Modified:
7 years ago

Reviewers:
dtu

CC:
chromium-reviews, chrome-speed-team+watch_google.com

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix media metrics reporting float values post crrev.com/84483002 Post the change, reporting metrics fails if passing an array of strings. This CL casts the values to floats before adding them. BUG=None NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238157

Patch Set 1 : #

Created: 7 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -1 line)			Patch
	M	tools/perf/metrics/media.py	View		1 chunk	+5 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shadi@chromium.org/83793013/20001

7 years ago (2013-12-02 19:50:39 UTC) #4

Message was sent while issue was closed.

Change committed as 238157

Expand Messages | Collapse Messages