NSS: Handle unfriendly tokens in client auth.

net/ssl/client_cert_store_impl.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_SSL_CLIENT_CERT_STORE_IMPL_H_
 #define NET_SSL_CLIENT_CERT_STORE_IMPL_H_
 
 #include "base/basictypes.h"
+#include "base/callback.h"
 #include "base/gtest_prod_util.h"
 #include "net/base/net_export.h"
 #include "net/ssl/client_cert_store.h"
 #include "net/ssl/ssl_cert_request_info.h"
 
+namespace crypto {
+class CryptoModuleBlockingPasswordDelegate;
+}
+
 namespace net {
 
 class NET_EXPORT ClientCertStoreImpl : public ClientCertStore {
  public:
-  ClientCertStoreImpl() {}
-  virtual ~ClientCertStoreImpl() {}
+  ClientCertStoreImpl();
+  virtual ~ClientCertStoreImpl();
 
   // ClientCertStore:
   virtual void GetClientCerts(const SSLCertRequestInfo& cert_request_info,
                               CertificateList* selected_certs,
                               const base::Closure& callback) OVERRIDE;
 
+#if defined(USE_NSS)
+  typedef base::Callback<crypto::CryptoModuleBlockingPasswordDelegate*(
+      const std::string&)> PasswordDelegateFactory;

[Ryan Sleevi, 2013/11/26 19:59:03]

Can you include a documentation note about what this callback (and the
associated parameter)

[mattm, 2013/11/26 21:49:14]

Done.

+  void set_password_delegate_factory(

[Ryan Sleevi, 2013/11/26 19:59:03]

style: Shouldn't this be SetPasswordDelegateFactory

[mattm, 2013/11/26 21:49:14]

Style guide says that simple setters & getters use the lower_underscore style:
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Function_Names

+      const PasswordDelegateFactory& password_delegate_factory);
+#endif
+
  private:
   friend class ClientCertStoreImplTest;
 
   // A hook for testing. Filters |input_certs| using the logic being used to
   // filter the system store when GetClientCerts() is called. Depending on the
   // implementation, this might be:
   // - Implemented by creating a temporary in-memory store and filtering it
   // using the common logic (preferable, currently on Windows).
   // - Implemented by creating a list of certificates that otherwise would be
   // extracted from the system store and filtering it using the common logic
   // (less adequate, currently on NSS and Mac).
   bool SelectClientCertsForTesting(const CertificateList& input_certs,
                                    const SSLCertRequestInfo& cert_request_info,
                                    CertificateList* selected_certs);
 
 #if defined(OS_MACOSX) && !defined(OS_IOS)
   // Testing hook specific to Mac, where the internal logic recognizes preferred
   // certificates for particular domains. If the preferred certificate is
   // present in the output list (i.e. it doesn't get filtered out), it should
   // always come first.
   bool SelectClientCertsGivenPreferredForTesting(
       const scoped_refptr<X509Certificate>& preferred_cert,
       const CertificateList& regular_certs,
       const SSLCertRequestInfo& request,
       CertificateList* selected_certs);
 #endif
 
+#if defined(USE_NSS)
+  // The factory for creating the delegate for requesting a password to a
+  // PKCS#11 token. May be null.
+  PasswordDelegateFactory password_delegate_factory_;
+#endif  // defined(USE_NSS)
+
   DISALLOW_COPY_AND_ASSIGN(ClientCertStoreImpl);
 };
 
 }  // namespace net
 
 #endif  // NET_SSL_CLIENT_CERT_STORE_IMPL_H_