Implement IPCs and VideoCapture::Client interfaces for texture capture

content/browser/renderer_host/media/video_capture_device_impl.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_RENDERER_HOST_VIDEO_CAPTURE_DEVICE_IMPL_H_
 #define CONTENT_BROWSER_RENDERER_HOST_VIDEO_CAPTURE_DEVICE_IMPL_H_
 
 #include <string>
 
 #include "base/memory/scoped_ptr.h"
 #include "base/memory/weak_ptr.h"
 #include "base/threading/thread.h"
 #include "base/threading/thread_checker.h"
 #include "content/browser/renderer_host/media/video_capture_oracle.h"
 #include "content/common/content_export.h"
 #include "media/video/capture/video_capture_device.h"
 
+namespace media {
+
+class VideoFrame;
+
+}  // namespace media
+
 namespace content {
 
 const int kMinFrameWidth = 2;
 const int kMinFrameHeight = 2;
 
 // Returns the nearest even integer closer to zero.
 template<typename IntType>
 IntType MakeEven(IntType x) {
   return x & static_cast<IntType>(-2);
 }
@@ skipping 44 matching lines @@
 
   // Signal an error to the client.
   void ReportError();
 
  private:
   friend class base::RefCountedThreadSafe<ThreadSafeCaptureOracle>;
   virtual ~ThreadSafeCaptureOracle();
 
   // Callback invoked on completion of all captures.
   void DidCaptureFrame(
-      scoped_refptr<media::VideoCaptureDevice::Client::Buffer> buffer,
+      const scoped_refptr<media::VideoCaptureDevice::Client::Buffer>& buffer,
+      const scoped_refptr<media::VideoFrame>& frame,
       int frame_number,
       base::TimeTicks timestamp,
       bool success);
   // Protects everything below it.
   base::Lock lock_;
 
   // Recipient of our capture activity.
   scoped_ptr<media::VideoCaptureDevice::Client> client_;
 
   // Makes the decision to capture a frame.
@@ skipping 38 matching lines @@
 // The "meat" of the video capture implementation.
 //
 // Separating this from the "shell classes" WebContentsVideoCaptureDevice and
 // BrowserCompositorCaptureDevice allows safe destruction without needing to
 // block any threads (e.g., the IO BrowserThread), as well as code sharing.
 //
 // VideoCaptureDeviceImpl manages a simple state machine and the pipeline (see
 // notes at top of this file).  It times the start of successive
 // captures and facilitates the processing of each through the stages of the
 // pipeline.
 class CONTENT_EXPORT VideoCaptureDeviceImpl

[jiayl, 2014/01/23 22:18:52]

The naming of the class seems very confusing because it does not implement
VideoCaptureDevice, and it's too general (it's only relevant for WebContents
video capture). Please consider renaming it to make it clearer that it's the
"meat" of WebContentsVideoCaptureDevice.

[sheu, 2014/01/29 01:19:20]

A little out of the scope of this change, probably.

[jiayl, 2014/01/31 19:32:38]

Then open a bug and add a TODO linked to the bug.

[sheu, 2014/02/07 00:37:25]

It's also used for the desktop capture device in Aura.  The use case is pretty
much any capturer that needs to be event-driven and throttled -- the immediate
case is tab/screen capturing.

I'm thinking ContentVideoCaptureDeviceimpl.  WDYT?

[jiayl, 2014/02/07 01:22:08]

I hope we can avoid "impl", e.g. VideoCaptureDeviceCore?

On 2014/02/07 00:37:25, sheu wrote:

     : public base::SupportsWeakPtr<VideoCaptureDeviceImpl> {
  public:
   VideoCaptureDeviceImpl(scoped_ptr<VideoCaptureMachine> capture_machine);
   virtual ~VideoCaptureDeviceImpl();
 
   // Asynchronous requests to change VideoCaptureDeviceImpl state.
   void AllocateAndStart(const media::VideoCaptureParams& params,
                         scoped_ptr<media::VideoCaptureDevice::Client> client);
   void StopAndDeAllocate();
 
@@ skipping 30 matching lines @@
   // system with direct access to |client_|.
   scoped_refptr<ThreadSafeCaptureOracle> oracle_proxy_;
 
   DISALLOW_COPY_AND_ASSIGN(VideoCaptureDeviceImpl);
 };
 
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_RENDERER_HOST_VIDEO_CAPTURE_DEVICE_IMPL_H_