linux aura: Show the drag-image when available.

linux aura: Show the drag-image when available.

This shows the snapshot of the dragged content during the drag (both for drags
from the web-contents, or from the UI (e.g. bookmark bar etc.)).

BUG=317993
R=erg@chromium.org, sky@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=236857

[sadrul, 2013-11-22 19:29:39]

I added a video of how it looks at
https://code.google.com/p/chromium/issues/detail?id=317993#c6

[Elliot Glaysher, 2013-11-22 20:19:19]

https://codereview.chromium.org/83783003/diff/1/ui/views/widget/desktop_aura/...
File ui/views/widget/desktop_aura/x11_whole_screen_move_loop.cc (right):

https://codereview.chromium.org/83783003/diff/1/ui/views/widget/desktop_aura/...
ui/views/widget/desktop_aura/x11_whole_screen_move_loop.cc:213:
Widget::InitParams params(Widget::InitParams::TYPE_POPUP);
I'm pretty sure you want to do something here that will set
_NET_WM_WINDOW_TYPE_DND. Add a type to Widget::InitParams::Type and check handle
it in DesktopRootWindowHostX11::InitX11Window()?

(A month or so ago, I wouldn't have blocked on this, but I've sort of learned
that window managers really care about the value of _NET_WM_WINDOW_TYPE.)

[sadrul, 2013-11-22 21:16:30]

https://codereview.chromium.org/83783003/diff/1/ui/views/widget/desktop_aura/...
File ui/views/widget/desktop_aura/x11_whole_screen_move_loop.cc (right):

https://codereview.chromium.org/83783003/diff/1/ui/views/widget/desktop_aura/...
ui/views/widget/desktop_aura/x11_whole_screen_move_loop.cc:213:
Widget::InitParams params(Widget::InitParams::TYPE_POPUP);
On 2013/11/22 20:19:19, Elliot Glaysher wrote:
> I'm pretty sure you want to do something here that will set
> _NET_WM_WINDOW_TYPE_DND. Add a type to Widget::InitParams::Type and check
handle
> it in DesktopRootWindowHostX11::InitX11Window()?
> 
> (A month or so ago, I wouldn't have blocked on this, but I've sort of learned
> that window managers really care about the value of _NET_WM_WINDOW_TYPE.)

Good point. Done.

[Elliot Glaysher, 2013-11-22 21:21:22]

lgtm

[sky, 2013-11-22 21:41:36]

LGTM

[sadrul, 2013-11-22 23:04:37]

Committed patchset #2 manually as r236857 (presubmit successful).