pkg/analysis_server/test/integration/protocol_matchers.dart - Issue 837793003: Include required parameter names when completing a method call.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/test/integration/protocol_matchers.dart

Issue 837793003: Include required parameter names when completing a method call. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Address comments Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/analysis_server/lib/src/services/completion/suggestion_builder.dart ('k') | pkg/analysis_server/test/services/completion/invocation_computer_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/test/integration/protocol_matchers.dart

diff --git a/pkg/analysis_server/test/integration/protocol_matchers.dart b/pkg/analysis_server/test/integration/protocol_matchers.dart

index f9cbc014b0d7f63073b0b02ea8bad4fd6946c6e4..df2c5f7f37574ada2103ccd3e6287b8c52aba285 100644

--- a/pkg/analysis_server/test/integration/protocol_matchers.dart

+++ b/pkg/analysis_server/test/integration/protocol_matchers.dart

@@ -1061,7 +1061,7 @@ final Matcher isCompletionRelevance = new MatchesEnum("CompletionRelevance", [

* "parameterNames": optional List<String>

* "parameterTypes": optional List<String>

* "requiredParameterCount": optional int

- * "positionalParameterCount": optional int

+ * "hasNamedParameters": optional bool

* "parameterName": optional String

* "parameterType": optional String

* }

@@ -1084,7 +1084,7 @@ final Matcher isCompletionSuggestion = new LazyMatcher(() => new MatchesJsonObje

"parameterNames": isListOf(isString),

"parameterTypes": isListOf(isString),

"requiredParameterCount": isInt,

- "positionalParameterCount": isInt,

+ "hasNamedParameters": isBool,

"parameterName": isString,

"parameterType": isString

}));