editor/tools/plugins/com.google.dart.server_test/src/com/google/dart/server/internal/remote/RemoteAnalysisServerImplTest.java - Issue 837793003: Include required parameter names when completing a method call.

Unified Diff: editor/tools/plugins/com.google.dart.server_test/src/com/google/dart/server/internal/remote/RemoteAnalysisServerImplTest.java

Issue 837793003: Include required parameter names when completing a method call. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/CompletionSuggestion.java ('k') | editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/completion/DartSuggestionReceiverTest.java » ('j') | editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/dart/DartServerProposal.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: editor/tools/plugins/com.google.dart.server_test/src/com/google/dart/server/internal/remote/RemoteAnalysisServerImplTest.java

diff --git a/editor/tools/plugins/com.google.dart.server_test/src/com/google/dart/server/internal/remote/RemoteAnalysisServerImplTest.java b/editor/tools/plugins/com.google.dart.server_test/src/com/google/dart/server/internal/remote/RemoteAnalysisServerImplTest.java

index 92dcdb01c06b04f75ab0b7ebe1155ddfd8f379ca..257cb45559531edb0813828695475b0476668349 100644

--- a/editor/tools/plugins/com.google.dart.server_test/src/com/google/dart/server/internal/remote/RemoteAnalysisServerImplTest.java

+++ b/editor/tools/plugins/com.google.dart.server_test/src/com/google/dart/server/internal/remote/RemoteAnalysisServerImplTest.java

@@ -1274,7 +1274,7 @@ public class RemoteAnalysisServerImplTest extends AbstractRemoteServerTest {

" 'parameterNames': ['param0', 'param1'],",

" 'parameterTypes': ['paramType0', 'paramType1'],",

" 'requiredParameterCount': 2,",

- " 'positionalParameterCount': 0,",

+ " 'hasNamedParameters': false,",

" 'parameterName': 'param2',",

" 'parameterType': 'paramType2',",

" 'element': {",

@@ -1331,7 +1331,7 @@ public class RemoteAnalysisServerImplTest extends AbstractRemoteServerTest {

assertThat(parameterTypes).contains("paramType0");

assertThat(parameterTypes).contains("paramType1");

assertEquals(suggestion.getRequiredParameterCount(), new Integer(2));

- assertEquals(suggestion.getPositionalParameterCount(), new Integer(0));

+ assertEquals(suggestion.getHasNamedParameters(), new Boolean(false));

assertEquals(suggestion.getParameterName(), "param2");

assertEquals(suggestion.getParameterType(), "paramType2");

{

@@ -1358,7 +1358,7 @@ public class RemoteAnalysisServerImplTest extends AbstractRemoteServerTest {

assertNull(suggestion.getParameterNames());

assertNull(suggestion.getParameterTypes());

assertNull(suggestion.getRequiredParameterCount());

- assertNull(suggestion.getPositionalParameterCount());

+ assertNull(suggestion.getHasNamedParameters());

assertNull(suggestion.getParameterName());

assertNull(suggestion.getParameterType());

{