Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(701)

Issue 837773008: TabPrinter: Verify the tab's state before printing (Closed)

Created:
5 years, 11 months ago by dgn
Modified:
5 years, 11 months ago
Reviewers:
Ted C
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

TabPrinter: Verify the tab's state before printing If the tab is instructed to print while the native side is not properly initialized, it will now fail gracefully instead of crashing. BUG=445467 Committed: https://crrev.com/c8076545db7f1d26298be68c1a278ff9b78ad343 Cr-Commit-Position: refs/heads/master@{#311347}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/android/java/src/org/chromium/chrome/browser/printing/TabPrinter.java View 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 7 (2 generated)
dgn
I did not manage to reproduce the issue, so I guess this will do. https://codereview.chromium.org/837773008/diff/1/chrome/android/java/src/org/chromium/chrome/browser/printing/TabPrinter.java ...
5 years, 11 months ago (2015-01-13 21:24:57 UTC) #2
Ted C
lgtm
5 years, 11 months ago (2015-01-13 21:30:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/837773008/1
5 years, 11 months ago (2015-01-13 21:36:51 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-13 22:27:55 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-13 22:28:39 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c8076545db7f1d26298be68c1a278ff9b78ad343
Cr-Commit-Position: refs/heads/master@{#311347}

Powered by Google App Engine
This is Rietveld 408576698