Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Issue 837773003: Revert of Revert of Enable display list 2D canvas by default (Closed)

Created:
5 years, 11 months ago by Justin Novosad
Modified:
5 years, 11 months ago
CC:
chromium-reviews, darin-cc_chromium.org, mkwst+moarreviews-shell_chromium.org, jam, jochen+watch_chromium.org, mlamouri+watch-content_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Revert of Enable display list 2D canvas by default (patchset #1 id:1 of https://codereview.chromium.org/824063002/) Reason for revert: The reason for the revert was resolved: crbug.com/445051 Original issue's description: > Revert of Enable display list 2D canvas by default (patchset #1 id:1 of https://codereview.chromium.org/818443002/) > > Reason for revert: > Breaks devtools highlight on hidpi screens. See crbug.com/445051. > > Original issue's description: > > Enable display list 2D canvas by default > > > > With this change, display list 2D canvas will become enabled by > > default in Chrome. Content shell with --dump-render-tree will > > continue to have display lists disabled by default. > > Currently, having display lists enabled in blink means > > that display lists will be used whenever 2d canvases would > > not be GPU-accelerated. > > > > BUG=386601 > > > > Committed: https://crrev.com/1546f423005338aac5961415bbfc48c61dc183ae > > Cr-Commit-Position: refs/heads/master@{#309453} > > TBR=avi@chromium.org,junov@chromium.org > NOTREECHECKS=true > NOTRY=true > BUG=386601 > > Committed: https://crrev.com/5b6f044b9bc14af9b265746d31db547be18d9dbb > Cr-Commit-Position: refs/heads/master@{#309635} TBR=avi@chromium.org,pfeldman@chromium.org NOTREECHECKS=true NOTRY=true BUG=386601 Committed: https://crrev.com/5d6c61887aebd1689283ceb0b01d0e1b9f431740 Cr-Commit-Position: refs/heads/master@{#310146}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -9 lines) Patch
M content/child/runtime_features.cc View 1 chunk +6 lines, -9 lines 0 comments Download
M content/shell/app/shell_main_delegate.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Justin Novosad
Created Revert of Revert of Enable display list 2D canvas by default
5 years, 11 months ago (2015-01-06 21:10:30 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/837773003/1
5 years, 11 months ago (2015-01-06 21:10:54 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-06 21:11:55 UTC) #3
commit-bot: I haz the power
5 years, 11 months ago (2015-01-06 21:12:57 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5d6c61887aebd1689283ceb0b01d0e1b9f431740
Cr-Commit-Position: refs/heads/master@{#310146}

Powered by Google App Engine
This is Rietveld 408576698