Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(446)

Unified Diff: pkg/analyzer/lib/instrumentation/instrumentation.dart

Issue 837753002: Tweak for escaping in instrumentation. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/analyzer/test/instrumentation/instrumentation_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/lib/instrumentation/instrumentation.dart
diff --git a/pkg/analyzer/lib/instrumentation/instrumentation.dart b/pkg/analyzer/lib/instrumentation/instrumentation.dart
index c2c1b96a28abe5800848c945c8d44e58b7b241fd..77547fbee5267f77df30737fd4b219a97465d5e4 100644
--- a/pkg/analyzer/lib/instrumentation/instrumentation.dart
+++ b/pkg/analyzer/lib/instrumentation/instrumentation.dart
@@ -135,7 +135,7 @@ class InstrumentationService {
}
/**
- * Write an escaped version of the given [string] to the given [buffer].
+ * Write an escaped version of the given [field] to the given [buffer].
*/
void _escape(StringBuffer buffer, String field) {
int index = field.indexOf(':');
@@ -144,7 +144,7 @@ class InstrumentationService {
return;
}
int start = 0;
- while (index > 0) {
+ while (index >= 0) {
buffer.write(field.substring(start, index));
buffer.write('::');
start = index + 1;
« no previous file with comments | « no previous file | pkg/analyzer/test/instrumentation/instrumentation_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698