Add tests for GetNamedDests() API.

fpdfsdk/src/fpdfview_embeddertest.cpp

 // Copyright 2015 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+#include <limits>
+#include <string>
+
 #include "../../testing/embedder_test.h"
+#include "../../fpdfsdk/include/fpdfview.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 class FPDFViewEmbeddertest : public EmbedderTest {
 };
 
 TEST_F(FPDFViewEmbeddertest, Document) {
   EXPECT_TRUE(OpenDocument("testing/resources/about_blank.pdf"));
   EXPECT_EQ(1, GetPageCount());
   EXPECT_EQ(0, GetFirstPageNum());
 
@@ skipping 17 matching lines @@
   ClearFormFillEnvironment(form_handle);
 }
 
 TEST_F(FPDFViewEmbeddertest, ViewerRef) {
   EXPECT_TRUE(OpenDocument("testing/resources/about_blank.pdf"));
   EXPECT_TRUE(FPDF_VIEWERREF_GetPrintScaling(document()));
   EXPECT_EQ(1, FPDF_VIEWERREF_GetNumCopies(document()));
   EXPECT_EQ(DuplexUndefined, FPDF_VIEWERREF_GetDuplex(document()));
 }
 
+TEST_F(FPDFViewEmbeddertest, NamedDests) {
+  EXPECT_TRUE(OpenDocument("testing/resources/named_dests.pdf"));
+  unsigned long buffer_size;
+  char fixed_buffer[512];
+  FPDF_DEST dest;
+
+  // Query the size of the first item.
+  buffer_size = 2000000; // Absurdly large, check not used for this case.
+  dest = FPDF_GetNamedDest(document(), 0, nullptr, buffer_size);
+  EXPECT_NE(nullptr, dest);
+  EXPECT_EQ(14u, buffer_size); // probably wrong, includes 4 NULs, not 2.
+
+  // Try to retrieve the first item with too small a buffer.
+  buffer_size = 10;
+  dest = FPDF_GetNamedDest(document(), 0, fixed_buffer, buffer_size);
+  EXPECT_NE(nullptr, dest);
+  EXPECT_EQ(static_cast<unsigned long>(-1), buffer_size);
+
+  // Try to retrieve the first item with correctly sized buffer.
+  buffer_size = 14;
+  dest = FPDF_GetNamedDest(document(), 0, fixed_buffer, buffer_size);
+  EXPECT_NE(nullptr, dest);
+  EXPECT_EQ(14u, buffer_size);
+  EXPECT_EQ(std::string("F\0i\0r\0s\0t\0\0\0\0\0", 14),
+            std::string(fixed_buffer, buffer_size));
+
+  // Try to retrieve the second item with ample buffer (item is indirected
+  // through another dictionary in named_dests.pdf).
+  buffer_size = sizeof(fixed_buffer);
+  dest = FPDF_GetNamedDest(document(), 1, fixed_buffer, buffer_size);
+  EXPECT_NE(nullptr, dest);
+  EXPECT_EQ(12u, buffer_size);  // probably wrong, includes 4 NULs, not 2.
+  EXPECT_EQ(std::string("N\0e\0x\0t\0\0\0\0\0", 12),
+            std::string(fixed_buffer, buffer_size));
+
+  // Try to retrieve third item with ample buffer (value has wrong type
+  // in named_dests.pdf).
+  buffer_size = sizeof(fixed_buffer);
+  dest = FPDF_GetNamedDest(document(), 2, fixed_buffer, buffer_size);
+  EXPECT_EQ(nullptr, dest);
+  EXPECT_EQ(sizeof(fixed_buffer), buffer_size);  // probably wrong, unmodified.
+
+  // Try to retrieve the forth item with ample buffer (item is indirected
+  // through another dictionary but with wrong key in named_dests.pdf).
+  buffer_size = sizeof(fixed_buffer);
+  dest = FPDF_GetNamedDest(document(), 3, fixed_buffer, buffer_size);
+  EXPECT_EQ(nullptr, dest);
+  EXPECT_EQ(sizeof(fixed_buffer), buffer_size);  // probably wrong, unmodified.
+
+
+  // Try to retrieve fifth item with ample buffer (item is in alternate
+  // dictionary object in named_dests.pdf).
+  buffer_size = sizeof(fixed_buffer);
+  dest = FPDF_GetNamedDest(document(), 4, fixed_buffer, buffer_size);
+  EXPECT_NE(nullptr, dest);
+  EXPECT_EQ(32u, buffer_size);  // probably wrong, includes 4 NULs, not 2.
+  EXPECT_EQ(
+      std::string("F\0i\0r\0s\0t\0A\0l\0t\0e\0r\0n\0a\0t\0e\0\0\0\0\0", 32),
+      std::string(fixed_buffer, buffer_size));
+
+  // Try to retrieve sixth item with ample buffer (item is in alternate
+  // dictionary object with valid indirect dictionary in named_dests.pdf).
+  buffer_size = sizeof(fixed_buffer);
+  dest = FPDF_GetNamedDest(document(), 5, fixed_buffer, buffer_size);
+  EXPECT_NE(nullptr, dest);
+  EXPECT_EQ(30u, buffer_size);  // probably wrong, unmodified.
+  EXPECT_EQ(
+      std::string("L\0a\0s\0t\0A\0l\0t\0e\0r\0n\0a\0t\0e\0\0\0\0\0", 30),
+      std::string(fixed_buffer, buffer_size));
+
+  // Try to retrieve non-existent item with ample buffer.
+  buffer_size = sizeof(fixed_buffer);
+  dest = FPDF_GetNamedDest(document(), 6, fixed_buffer, buffer_size);
+  EXPECT_EQ(nullptr, dest);
+  EXPECT_EQ(sizeof(fixed_buffer), buffer_size);  // probably wrong, unmodified.
+
+  // Try to underflow/overflow the integer index.
+  buffer_size = sizeof(fixed_buffer);
+  dest = FPDF_GetNamedDest(document(), std::numeric_limits<int>::max(),
+                           fixed_buffer, buffer_size);
+  EXPECT_EQ(nullptr, dest);
+  EXPECT_EQ(sizeof(fixed_buffer), buffer_size);
+
+  buffer_size = sizeof(fixed_buffer);
+  dest = FPDF_GetNamedDest(document(), std::numeric_limits<int>::max(),
+                           fixed_buffer, buffer_size);
+  EXPECT_EQ(nullptr, dest);
+  EXPECT_EQ(sizeof(fixed_buffer), buffer_size);
+
+  buffer_size = sizeof(fixed_buffer);
+  dest = FPDF_GetNamedDest(document(), -1, fixed_buffer, buffer_size);
+  EXPECT_EQ(nullptr, dest);
+  EXPECT_EQ(sizeof(fixed_buffer), buffer_size);
+}