Add tests for GetNamedDests() API.

fpdfsdk/src/fpdfview.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
  
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "../include/fsdk_define.h"
 #include "../include/fsdk_mgr.h"
 #include "../include/fpdfview.h"
 #include "../include/fsdk_rendercontext.h"
@@ skipping 799 matching lines @@
         if (!document)
                 return NULL;
         if (!name || name[0] == 0) 
                 return NULL;
 
         CPDF_Document* pDoc = (CPDF_Document*)document;
         CPDF_NameTree name_tree(pDoc, FX_BSTRC("Dests"));
         return name_tree.LookupNamedDest(pDoc, name);
 }
 
 DLLEXPORT FPDF_DEST STDCALL FPDF_GetNamedDest(FPDF_DOCUMENT document, int index, void* buffer, unsigned long& buflen)

[Bo Xu, 2015/01/21 00:04:12]

Shall we use long instead of unsigned long for buflen, regarding the -1 return
value?

 {
     if (!buffer)
         buflen = 0;
     if (!document || index < 0) return NULL;
     CPDF_Document* pDoc = (CPDF_Document*)document;
 
     CPDF_Dictionary* pRoot = pDoc->GetRoot();
     if (!pRoot) return NULL;
 
     CPDF_Object* pDestObj = NULL;
@@ skipping 10 matching lines @@
         while (pos) {
             pDestObj = pDest->GetNextElement(pos, bsName);
             if (!pDestObj) continue;
             if (i == index) break;
             i++;
         }
     } else {
         pDestObj = nameTree.LookupValue(index, bsName);
     }
     if (!pDestObj) return NULL;
-    if (pDestObj->GetType() == PDFOBJ_DICTIONARY)
+    if (pDestObj->GetType() == PDFOBJ_DICTIONARY) {
         pDestObj = ((CPDF_Dictionary*)pDestObj)->GetArray(FX_BSTRC("D"));
+        if (!pDestObj) return NULL;
+    }
     if (pDestObj->GetType() != PDFOBJ_ARRAY) return NULL;
     CFX_WideString wsName = PDF_DecodeText(bsName);
     CFX_ByteString utf16Name = wsName.UTF16LE_Encode();
     unsigned int len = utf16Name.GetLength();
     if (!buffer) {
         buflen = len + 2;
     } else if (buflen >= len + 2) {
         memcpy(buffer, utf16Name.c_str(), len);
         ((FX_BYTE*)buffer)[len] = 0;
         ((FX_BYTE*)buffer)[len + 1] = 0;
+        buflen = len + 2;
     } else {
-        len = -1;
+        buflen = -1;
     }
     return (FPDF_DEST)pDestObj;
 }